feat(frontend): implement saved searches core logic and UI updates#2424
Merged
jcscottiii merged 2 commits intomainfrom Apr 22, 2026
Merged
feat(frontend): implement saved searches core logic and UI updates#2424jcscottiii merged 2 commits intomainfrom
jcscottiii merged 2 commits intomainfrom
Conversation
3535431 to
33f9f3b
Compare
90351c9 to
a98abc7
Compare
8583cf9 to
a0fa5b0
Compare
a98abc7 to
66123c6
Compare
66123c6 to
f6dec4a
Compare
f6dec4a to
9c42510
Compare
jrobbins
approved these changes
Apr 18, 2026
neilv-g
approved these changes
Apr 20, 2026
9018e18 to
4bc92ba
Compare
9393b85 to
9e6fd43
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
feat(frontend): implement saved searches core logic and UI updatesDescription:
This PR implements the core logic and UI updates for saved searches on the frontend, completing the migration to a unified search experience.
Why:
Previously, saved searches were tracked using a dedicated
search_idURL parameter. This prevented users from combining a saved search with additional filters in the search bar. This PR migrates to usingsaved:IDandhotlist:IDdirectly within theqsearch parameter, enabling full composability of search terms.Key Changes:
search_idURL parameter withsaved:ID(user searches) andhotlist:ID(global searches) within theqparameter. Updatedapp-bookmark-info-context.tsto parse these new tokens.DEFAULT_GLOBAL_SAVED_SEARCHESconstants. Global searches are now fetched dynamically from the backend via the new/v1/global-saved-searchesendpoint.reorderByQueryTermsfromwebstatus-overview-data-loader.ts. Sorting by saved search order is now handled by the backend (implemented in PR feat(search): add query expansion for saved searches #2421), making client-side reordering redundant.OverviewPageto automatically detectsearch_idin the URL and redirect to the equivalentq=saved:IDformat with a user toast notification.waitForSidebarLoadedin E2E tests to reduce flakiness caused by visual regression checks firing before the sidebar hydrated.Anti-Patterns / Known Debt:
popstateevent inurls.tsas a workaround to force Vaadin Router to update its location state. This is tracked in issue [ENHANCEMENT] Migrate off of deprecated router #2020 and should be removed when we migrate to aURLPattern-based router.