feat: Add ability for users to subscribe to updates for individual features - #2232
Merged
Conversation
jcscottiii
reviewed
Feb 5, 2026
neilv-g
force-pushed
the
feature-sub-button
branch
from
February 9, 2026 18:26
3c1bfcd to
6a3706e
Compare
jcscottiii
reviewed
Feb 9, 2026
jcscottiii
left a comment
jcscottiii
left a comment
Collaborator
There was a problem hiding this comment.
One nit and you will need to update the screenshots.
You can follow the instructions here.
I do the SKIP_FRESH_ENV method instead of running make playwright-update-snapshots without it. While you have to manually run the commands to set up your environment, you have more control if you need to re-run a test. And you can also configure visual studio code afterwards to regenerate for individual tests if needed too.
neilv-g
force-pushed
the
feature-sub-button
branch
4 times, most recently
from
February 10, 2026 12:25
f43a27a to
7b17788
Compare
jcscottiii
reviewed
Feb 10, 2026
jcscottiii
left a comment
jcscottiii
left a comment
Collaborator
There was a problem hiding this comment.
LGTM on the frontend. One comment on the spanner code.
neilv-g
force-pushed
the
feature-sub-button
branch
from
February 11, 2026 19:27
7b17788 to
6f60130
Compare
Notification subscription status is loaded on button click. Other misc changes: - Updated 'make dev_fake_data' flow to populate SystemManagedSavedSearches table - The button would not open a second time on a single page load, so there are some changes to fix that in the ts files (i.e. dialog box would not open if you clicked subscribe, closed the dialog box, then tried clicking subscribe again)
neilv-g
force-pushed
the
feature-sub-button
branch
from
February 11, 2026 21:55
6f60130 to
a5687b7
Compare
jcscottiii
approved these changes
Feb 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a feature detail page, a new 'user_subscription_id' ID field is returned (if the user is logged in) to indicate whether the user is subscribed to updates on the feature (i.e. if they have a entry in SavedSearchSubscriptions for the feature with the features' SystemManagedSavedSearch).
The frontend checks for the presence of this field and shows the button and appropriate text ('Subscribe to updates' vs 'Manage subscription').
Other misc changes: