[AND-1410] Correctly register Telecom video and streaming capabilities - #1775
Draft
rahul-lohra wants to merge 1 commit into
Draft
[AND-1410] Correctly register Telecom video and streaming capabilities#1775rahul-lohra wants to merge 1 commit into
rahul-lohra wants to merge 1 commit into
Conversation
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Goal
Closes #AND-1410
Correct the app-wide Jetpack Telecom capability registration. The existing implementation combines the video-calling and call-streaming flags using bitwise
and, which evaluates to0because the flags occupy different bits.Use bitwise
orso Android Telecom is correctly informed that the SDK supports both capabilities.Basic Telecom integration and audio routing worked because AndroidX still registered a self-managed account and the per-call attributes were correct. However, app-wide video and call-streaming capabilities were missing because the capability mask evaluated to zero.
Implementation
or.both passed to
registerAppWithTelecom.🎨 UI Changes
None
Testing
Smoke test with telecom enabled