Update min deployment target of Xcode schemes - #1591
Merged
Conversation
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (43)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (47)
📒 Files selected for processing (10)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe change adds environment-controlled liquid glass rendering, effect-free snapshot helpers and test migrations, and iOS 15 deployment targets for affected framework and test targets. ChangesLiquid Glass Controls and Snapshot Updates
iOS 15 Deployment Target Alignment
Priority: ⬇️ Low — Defer this change because it updates SwiftUI deployment settings, liquid-glass handling, and snapshot rendering without changing public APIs or described runtime features. Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk remains. Sequence Diagram(s)sequenceDiagram
participant SnapshotTest
participant StreamChatTestCase
participant SwiftUIEnvironment
participant LiquidGlassModifiers
SnapshotTest->>StreamChatTestCase: assertSnapshotWithoutVisualEffects(view)
StreamChatTestCase->>SwiftUIEnvironment: disable liquid glass effects
SwiftUIEnvironment->>LiquidGlassModifiers: provide disabled setting
LiquidGlassModifiers->>StreamChatTestCase: render without visual effects
StreamChatTestCase->>SnapshotTest: compare rendered image
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nuno-vieira
approved these changes
Sep 7, 2026
martinmitrevski
enabled auto-merge (squash)
September 7, 2026 15:13
martinmitrevski
disabled auto-merge
September 8, 2026 15:12
Generated by 🚫 Danger |
Collaborator
SDK Size
|
Collaborator
StreamChatSwiftUI XCSize
Show 131 more objects
|
nuno-vieira
approved these changes
Sep 8, 2026
Public Interface🚀 No changes affecting the public interface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolves https://linear.app/stream/issue/IOS-2010/build-demo-app-on-xcode-27.
🎯 Goal
Make the demo app build on Xcode 27.
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
docs-contentrepoSummary by CodeRabbit
New Features
Compatibility
Tests