Skip to content

feat(app): signup-confirmation deep link + restore pulse:// scheme - #49

Merged
GJanos merged 1 commit into
developfrom
feat/signup-confirm-deeplink
Jun 17, 2026
Merged

GJanos merged 1 commit into
developfrom
feat/signup-confirm-deeplink

Conversation

@GJanos

@GJanos GJanos commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Summary

Fixes the account-deletion → re-signup confirmation deep link, and a regression where no pulse:// deep link worked.

Root cause (deep links): the rebuilt app dropped the pulse:// URL scheme that the legacy app.json declared. With no scheme registered, Android could not route Supabase's /verify redirect (pulse://reset-password… / pulse://confirm…) back into the app — so both reset-password and signup confirmation silently failed. (The android/ dir is gitignored/prebuild-generated, so the fix lives in app.json.)

Changes

  • app.json: re-add scheme: "pulse" → prebuild regenerates the BROWSABLE intent-filter.
  • signUp: pass emailRedirectTo: 'pulse://confirm'.
  • useDeepLinkRecovery: handle pulse://confirm as a non-recovery flow — establish the session (SIGNED_IN routes into the app) without entering password-recovery mode. pulse://reset-password behavior unchanged.
  • LoginScreen: drop KeyboardAvoidingView behavior="height" on Android (it fights the manifest's adjustResize and left an uncovered strip revealing the native, theme-mismatched window background as a grey band).
  • withNavigationBarContrast plugin (new): disable enforceNavigationBarContrast so the transparent nav bar doesn't paint a grey scrim under edge-to-edge.

Testing

  • tsc / eslint / prettier clean; 507/507 jest pass (new tests cover the confirm parse + handler paths and the emailRedirectTo option).
  • Verified on-device: pulse://confirm and pulse://reset-password both route into the running app; login grey band gone across themes.
  • /security-review run on the auth/deep-link changes — no findings.

Reviewer notes

  • Requires a native rebuild (expo prebuild --clean && expo run:android) to pick up the scheme + plugin.
  • No Supabase dashboard change needed — redirect allowlist (pulse://**) already covers it.

🤖 Generated with Claude Code

The rebuilt app dropped the `pulse://` URL scheme (legacy app.json declared
it), so Android could not route the Supabase /verify redirect back into the
app — both reset-password and signup-confirmation deep links silently failed.

- app.json: re-add `scheme: "pulse"` so prebuild regenerates the BROWSABLE
  intent-filter for the custom scheme.
- signUp: pass `emailRedirectTo: 'pulse://confirm'`.
- useDeepLinkRecovery: handle `pulse://confirm` as a non-recovery flow —
  exchange the code/tokens to establish the session (SIGNED_IN routes into
  the app) without entering password-recovery mode.
- LoginScreen: drop KeyboardAvoidingView `behavior="height"` on Android; it
  fights the manifest's adjustResize and leaves an uncovered strip that
  reveals the native (theme-mismatched) window background as a grey band.
- withNavigationBarContrast plugin: disable enforceNavigationBarContrast so
  the transparent nav bar doesn't paint a grey scrim under edge-to-edge.
- Tests for the confirm parse/handler paths and the emailRedirectTo option.

Verified on-device: pulse://confirm and pulse://reset-password both route
into the app; login grey band gone.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@GJanos
GJanos merged commit 09cd569 into develop Jun 17, 2026
5 checks passed
@GJanos
GJanos deleted the feat/signup-confirm-deeplink branch June 17, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant