Repository navigation
feat(app): signup-confirmation deep link + restore pulse:// scheme - #49
Merged
Merged
Conversation
The rebuilt app dropped the `pulse://` URL scheme (legacy app.json declared it), so Android could not route the Supabase /verify redirect back into the app — both reset-password and signup-confirmation deep links silently failed. - app.json: re-add `scheme: "pulse"` so prebuild regenerates the BROWSABLE intent-filter for the custom scheme. - signUp: pass `emailRedirectTo: 'pulse://confirm'`. - useDeepLinkRecovery: handle `pulse://confirm` as a non-recovery flow — exchange the code/tokens to establish the session (SIGNED_IN routes into the app) without entering password-recovery mode. - LoginScreen: drop KeyboardAvoidingView `behavior="height"` on Android; it fights the manifest's adjustResize and leaves an uncovered strip that reveals the native (theme-mismatched) window background as a grey band. - withNavigationBarContrast plugin: disable enforceNavigationBarContrast so the transparent nav bar doesn't paint a grey scrim under edge-to-edge. - Tests for the confirm parse/handler paths and the emailRedirectTo option. Verified on-device: pulse://confirm and pulse://reset-password both route into the app; login grey band gone. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the account-deletion → re-signup confirmation deep link, and a regression where no
pulse://deep link worked.Root cause (deep links): the rebuilt app dropped the
pulse://URL scheme that the legacyapp.jsondeclared. With no scheme registered, Android could not route Supabase's/verifyredirect (pulse://reset-password…/pulse://confirm…) back into the app — so both reset-password and signup confirmation silently failed. (Theandroid/dir is gitignored/prebuild-generated, so the fix lives inapp.json.)Changes
app.json: re-addscheme: "pulse"→ prebuild regenerates the BROWSABLE intent-filter.signUp: passemailRedirectTo: 'pulse://confirm'.useDeepLinkRecovery: handlepulse://confirmas a non-recovery flow — establish the session (SIGNED_IN routes into the app) without entering password-recovery mode.pulse://reset-passwordbehavior unchanged.LoginScreen: dropKeyboardAvoidingView behavior="height"on Android (it fights the manifest'sadjustResizeand left an uncovered strip revealing the native, theme-mismatched window background as a grey band).withNavigationBarContrastplugin (new): disableenforceNavigationBarContrastso the transparent nav bar doesn't paint a grey scrim under edge-to-edge.Testing
tsc/ eslint / prettier clean; 507/507 jest pass (new tests cover the confirm parse + handler paths and theemailRedirectTooption).pulse://confirmandpulse://reset-passwordboth route into the running app; login grey band gone across themes./security-reviewrun on the auth/deep-link changes — no findings.Reviewer notes
expo prebuild --clean && expo run:android) to pick up the scheme + plugin.pulse://**) already covers it.🤖 Generated with Claude Code