Repository navigation
ci(CodeQuality): run ESLint as a separate step - #115
Merged
Merged
Conversation
Deploying devjamtw2025 with
|
| Latest commit: |
31e606f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://153a9ee5.devjamtw2025.pages.dev |
| Branch Preview URL: | https://ci-add-lint-step.devjamtw2025.pages.dev |
NaoCoding
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm lintstep to the Code Quality workflow, between Prettier and the build.next buildlogs ESLint crashes but keeps building, so PRs that break the ESLint config still show green CI. Renovate PRs fix(deps): update nextjs monorepo to v16 #83 (eslint-config-next 16) and chore(deps): update dependency eslint to v10 #86 (eslint 10) both passed CI while ESLint failed to load.pnpm lintexits non-zero when ESLint cannot load, so those PRs will now fail CI.Notes
Imageimport inHomeInformation.tsx) do not fail the step.next lintis deprecated and removed in Next.js 16; switch thelintscript toeslint .as part of that upgrade.Test plan
pnpm lintexits 0 on current mainpnpm lintexits 1 on the eslint 10 branch (chore(deps): update dependency eslint to v10 #86)