Kleine Verbesserungen und RexStan-Fixes (v1.3.1)#17
Open
skerbis wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares a 1.3.1 patch release for the BlockPeek REDAXO addon, focusing on RexStan-driven hardening and more robust backend preview rendering/configuration behavior.
Changes:
- Hardened settings access and template saving by adding admin null-safety and validating the required
BLOCK_PEEK_CONTENTplaceholder. - Improved preview rendering stability by safely flipping/restoring REDAXO context for
force_feand tightening parameter handling/types for extension points. - Limited backend asset loading to
content/editand bumped versions/changelog for the 1.3.1 release.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pages/settings.php | Adds user null-check and validates template placeholder before persisting changes. |
| boot.php | Loads BlockPeek assets only on content/edit and uses addon instance for asset URLs. |
| lib/Generator.php | Tightens constructor typing and ensures force_fe context is restored via try/finally. |
| lib/Extension.php | Adds generic EP annotation, defensive param parsing, safer updatedate casting, and safer srcdoc escaping. |
| lib/TemplateInstaller.php | Uses rex_file::get() for default template content loading with fallback. |
| lib/TemplateListHider.php | Adds generic EP annotation and removes now-redundant subject type guard. |
| lang/en_gb.lang | Adds i18n string for missing placeholder validation error. |
| lang/de_de.lang | Adds i18n string for missing placeholder validation error. |
| package.yml | Bumps addon version to 1.3.1. |
| package.json | Syncs asset build package version to 1.3.1. |
| package-lock.json | Syncs lockfile package version to 1.3.1. |
| CHANGELOG.md | Adds 1.3.1 changelog entry describing fixes and adjustments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moin
Yves hier ein paar kleine Verbesserungen, hatte gerade Zeit, also dachte ich mir ..
Ich habe ein paar Stabilitäts- und Qualitätsfixes für BlockPeek umgesetzt und direkt als Patch-Release vorbereitet.
Enthalten:
RexStan läuft für das Addon ohne Fehler durch.