Skip to content

Use primary key instead of binding key in case of BelongsToMany association #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ravage84 wants to merge 3 commits into
base: 6.x
Choose a base branch
from
Draft

Use primary key instead of binding key in case of BelongsToMany association #711

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
537cd38
Use primary key instead of binding key in case of BelongsToMany assoc…
ravage84 Jan 18, 2024
a70c431
Import BelongsToMany
ravage84 Jan 19, 2024
d4c42f9
Associate blogs fixture with users to test related models
ravage84 Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Listener/RelatedModelsListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,12 @@ public function publishRelatedModels(?string $action = null, ?EntityInterface $e
*/
protected function _findOptions(Association $association): array
{
if ($association instanceof Association\BelongsToMany) {
Comment thread
ravage84 marked this conversation as resolved.
Outdated
return [
'keyField' => $association->getPrimaryKey(),
];
}

return [
'keyField' => $association->getBindingKey(),
];

@ravage84 ravage84 Jan 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, the code could look like this:

Suggested change
if ($association instanceof Association\BelongsToMany) {
return [
'keyField' => $association->getPrimaryKey(),
];
}
return [
'keyField' => $association->getBindingKey(),
];
$keyField = $association->getBindingKey();
if ($association instanceof Association\BelongsToMany) {
$keyField = $association->getPrimaryKey();
}
return [
'keyField' =>$keyField,
];

Expand Down