Skip to content

rendering: make LegacyGL traversal optional #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tritao wants to merge 2 commits into from
Open

rendering: make LegacyGL traversal optional #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0adc361
rendering: make LegacyGL traversal optional
tritao Aug 11, 2026
2b8f67a
tests: preserve core traversal without LegacyGL
tritao Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLAppearance.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ class COIN_DLL_API SoVRMLAppearance : public SoNode

void doAction(SoAction * action) override;
void callback(SoCallbackAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void search(SoSearchAction * action) override;

SoChildList * getChildren(void) const override;
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLBackground.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ class COIN_DLL_API SoVRMLBackground : public SoNode
SoMFString rightUrl;
SoMFString topUrl;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender( SoGLRenderAction * action ) override;
#endif

protected:
SbBool readInstance(SoInput * in, unsigned short flags) override;
Expand Down
4 changes: 4 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLBillboard.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,19 @@ class COIN_DLL_API SoVRMLBillboard : public SoVRMLParent

void doAction(SoAction * action) override;
void callback(SoCallbackAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void getBoundingBox(SoGetBoundingBoxAction * action) override;
void getMatrix(SoGetMatrixAction * action) override;
void pick(SoPickAction * action) override;
void search(SoSearchAction * action) override;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRenderBelowPath(SoGLRenderAction * action) override;
void GLRenderInPath(SoGLRenderAction * action) override;
void GLRenderOffPath(SoGLRenderAction * action) override;
#endif

void notify(SoNotList * list) override;

Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLBox.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ class COIN_DLL_API SoVRMLBox : public SoVRMLGeometry

SoSFVec3f size;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void rayPick(SoRayPickAction * action) override;
void getPrimitiveCount( SoGetPrimitiveCountAction * action ) override;

Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLCollision.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ class COIN_DLL_API SoVRMLCollision : public SoVRMLGroup
SoSFNode proxy;
SoSFTime collideTime;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif

void notify(SoNotList * list) override;

Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLColor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ class COIN_DLL_API SoVRMLColor : public SoNode
SoMFColor color;

void doAction(SoAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void callback(SoCallbackAction * action) override;

protected:
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLCone.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ class COIN_DLL_API SoVRMLCone : public SoVRMLGeometry
SoSFBool side;
SoSFBool bottom;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void rayPick(SoRayPickAction * action) override;
void getPrimitiveCount(SoGetPrimitiveCountAction * action) override;

Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLCoordinate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ class COIN_DLL_API SoVRMLCoordinate : public SoNode
SoMFVec3f point;

void doAction( SoAction * action ) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender( SoGLRenderAction * action ) override;
#endif
void getBoundingBox( SoGetBoundingBoxAction * action ) override;
void callback( SoCallbackAction * action ) override;
void pick( SoPickAction * action ) override;
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLCylinder.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ class COIN_DLL_API SoVRMLCylinder : public SoVRMLGeometry
SoSFBool top;
SoSFBool bottom;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void rayPick(SoRayPickAction * action) override;
void getPrimitiveCount(SoGetPrimitiveCountAction * action) override;

Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLDirectionalLight.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ class COIN_DLL_API SoVRMLDirectionalLight : public SoVRMLLight

SoSFVec3f direction;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender( SoGLRenderAction * action ) override;
#endif

protected:
virtual ~SoVRMLDirectionalLight();
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLElevationGrid.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ class COIN_DLL_API SoVRMLElevationGrid : public SoVRMLGeometry
SoSFBool colorPerVertex;
SoSFBool normalPerVertex;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void rayPick(SoRayPickAction * action) override;
void getPrimitiveCount(SoGetPrimitiveCountAction * action) override;

Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLExtrusion.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,9 @@ class COIN_DLL_API SoVRMLExtrusion : public SoVRMLGeometry
SoSFBool solid;
SoMFVec3f spine;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void getPrimitiveCount(SoGetPrimitiveCountAction * action) override;
virtual void computeBBox(SoAction * action,
SbBox3f & bbox, SbVec3f & center) override;
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLFog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ class COIN_DLL_API SoVRMLFog : public SoNode
SoSFFloat visibilityRange;
SoSFColor color;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender( SoGLRenderAction * action ) override;
#endif

protected:
SoSFBool set_bind;
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLFontStyle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ class COIN_DLL_API SoVRMLFontStyle : public SoNode

void doAction(SoAction * action) override;
void callback(SoCallbackAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void getBoundingBox(SoGetBoundingBoxAction * action) override;
void pick(SoPickAction * action) override;
void getPrimitiveCount(SoGetPrimitiveCountAction * action) override;
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLGeometry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ class COIN_DLL_API SoVRMLGeometry : public SoShape
virtual ~SoVRMLGeometry();

void setupShapeHints(SoState * state, const SbBool ccw, const SbBool solid);
#if COIN_HAVE_LEGACY_GL_RENDERER
SbBool shouldGLRender(SoGLRenderAction * action) override;
#endif
SoChildList * getChildren(void) const override;
void notify(SoNotList * list) override;

Expand Down
4 changes: 4 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLGroup.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ class COIN_DLL_API SoVRMLGroup : public SoVRMLParent

void doAction(SoAction * action) override;
void callback(SoCallbackAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void getBoundingBox(SoGetBoundingBoxAction * action) override;
void getMatrix(SoGetMatrixAction * action) override;
void rayPick(SoRayPickAction * action) override;
Expand All @@ -78,9 +80,11 @@ class COIN_DLL_API SoVRMLGroup : public SoVRMLParent
void getPrimitiveCount(SoGetPrimitiveCountAction * action) override;
void audioRender(SoAudioRenderAction * action) override;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRenderBelowPath(SoGLRenderAction * action) override;
void GLRenderInPath(SoGLRenderAction * action) override;
void GLRenderOffPath(SoGLRenderAction * action) override;
#endif

void notify(SoNotList * list) override;

Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLImageTexture.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ class COIN_DLL_API SoVRMLImageTexture : public SoVRMLTexture
void allowPrequalifyFile(SbBool enable);

void doAction(SoAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void callback(SoCallbackAction * action) override;
void rayPick(SoRayPickAction * action) override;

Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLIndexedFaceSet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ class COIN_DLL_API SoVRMLIndexedFaceSet : public SoVRMLIndexedShape
SoSFBool convex;
SoSFFloat creaseAngle;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender( SoGLRenderAction * action ) override;
#endif
void getPrimitiveCount( SoGetPrimitiveCountAction * action ) override;

SbBool generateDefaultNormals(SoState * s, SoNormalBundle * nb ) override;
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLIndexedLineSet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ class COIN_DLL_API SoVRMLIndexedLineSet : public SoVRMLIndexedLine
static void initClass(void);
SoVRMLIndexedLineSet(void);

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void getPrimitiveCount(SoGetPrimitiveCountAction * action) override;
void getBoundingBox(SoGetBoundingBoxAction * action) override;

Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLInline.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,9 @@ class COIN_DLL_API SoVRMLInline : public SoNode

void doAction(SoAction * action) override;
void callback(SoCallbackAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void getBoundingBox(SoGetBoundingBoxAction * action) override;
void getMatrix(SoGetMatrixAction * action) override;
void handleEvent(SoHandleEventAction * action) override;
Expand Down
4 changes: 4 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLLOD.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,21 @@ class COIN_DLL_API SoVRMLLOD : public SoGroup

void doAction(SoAction * action) override;
void callback(SoCallbackAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void rayPick(SoRayPickAction * action) override;
void getBoundingBox(SoGetBoundingBoxAction * action) override;
void search(SoSearchAction * action) override;
void write(SoWriteAction * action) override;
void getPrimitiveCount(SoGetPrimitiveCountAction * action) override;
void audioRender(SoAudioRenderAction * action) override;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRenderBelowPath(SoGLRenderAction * action) override;
void GLRenderInPath(SoGLRenderAction * action) override;
void GLRenderOffPath(SoGLRenderAction * action) override;
#endif

void addChild(SoNode * child) override;
void insertChild(SoNode * child, int idx) override;
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLLight.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ class COIN_DLL_API SoVRMLLight : public SoNode
SoSFColor color;
SoSFFloat ambientIntensity;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif

protected:
SoVRMLLight(void);
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLMaterial.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ class COIN_DLL_API SoVRMLMaterial : public SoNode
SoSFFloat transparency;

void doAction(SoAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void callback(SoCallbackAction * action) override;

protected:
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLMovieTexture.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,9 @@ class COIN_DLL_API SoVRMLMovieTexture : public SoVRMLTexture
SoSFColor blendColor;
SoSFBool scaleTexCoord;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender( SoGLRenderAction * action ) override;
#endif

protected:
virtual ~SoVRMLMovieTexture();
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLNavigationInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ class COIN_DLL_API SoVRMLNavigationInfo : public SoNode
SoSFFloat visibilityLimit;
SoSFBool headlight;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender( SoGLRenderAction * action ) override;
#endif

protected:
virtual ~SoVRMLNavigationInfo();
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLNormal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ class COIN_DLL_API SoVRMLNormal : public SoNode
SoMFVec3f vector;

void doAction(SoAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void callback(SoCallbackAction * action) override;
void pick(SoPickAction * action) override;
void getPrimitiveCount(SoGetPrimitiveCountAction * action) override;
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLPixelTexture.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ class COIN_DLL_API SoVRMLPixelTexture : public SoVRMLTexture
SoSFImage image;

void doAction(SoAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void callback(SoCallbackAction * action) override;
void rayPick(SoRayPickAction * action) override;

Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLPointLight.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ class COIN_DLL_API SoVRMLPointLight : public SoVRMLLight
SoSFFloat radius;
SoSFVec3f attenuation;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender( SoGLRenderAction * action ) override;
#endif

protected:
virtual ~SoVRMLPointLight();
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLPointSet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ class COIN_DLL_API SoVRMLPointSet : public SoVRMLVertexPoint
static void initClass(void);
SoVRMLPointSet(void);

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void getBoundingBox(SoGetBoundingBoxAction * action) override;

protected:
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLProximitySensor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ class COIN_DLL_API SoVRMLProximitySensor : public SoNode
SbBool affectsState(void) const override;

void doAction(SoAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void callback(SoCallbackAction * action) override;
void rayPick(SoRayPickAction * action) override;
void getBoundingBox(SoGetBoundingBoxAction * action) override;
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLScript.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ class COIN_DLL_API SoVRMLScript : public SoNode

void doAction(SoAction * action) override;
void callback(SoCallbackAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void getBoundingBox(SoGetBoundingBoxAction * action) override;
void pick(SoPickAction * action) override;
void handleEvent(SoHandleEventAction * action) override;
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLShape.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ class COIN_DLL_API SoVRMLShape : public SoNode

void doAction(SoAction * action) override;
void callback(SoCallbackAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void getBoundingBox(SoGetBoundingBoxAction * action) override;
void rayPick(SoRayPickAction * action) override;
void search(SoSearchAction * action) override;
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLSphere.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ class COIN_DLL_API SoVRMLSphere : public SoVRMLGeometry

SoSFFloat radius;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void rayPick(SoRayPickAction * action) override;
void getPrimitiveCount(SoGetPrimitiveCountAction * action) override;

Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLSpotLight.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ class COIN_DLL_API SoVRMLSpotLight : public SoVRMLLight
SoSFFloat radius;
SoSFVec3f attenuation;

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender( SoGLRenderAction * action ) override;
#endif

protected:
virtual ~SoVRMLSpotLight();
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLSwitch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ class COIN_DLL_API SoVRMLSwitch : public SoGroup

void doAction(SoAction * action) override;
void callback(SoCallbackAction * action) override;
#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void pick(SoPickAction * action) override;
void getBoundingBox(SoGetBoundingBoxAction * action) override;
void handleEvent(SoHandleEventAction * action) override;
Expand Down
2 changes: 2 additions & 0 deletions include/Inventor/VRMLnodes/SoVRMLText.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ class COIN_DLL_API SoVRMLText : public SoVRMLGeometry
MIDDLE = 0x03
};

#if COIN_HAVE_LEGACY_GL_RENDERER
void GLRender(SoGLRenderAction * action) override;
#endif
void getPrimitiveCount(SoGetPrimitiveCountAction * action) override;

void notify(SoNotList * list) override;
Expand Down
Loading