build: establish profile-aware OpenGL headers - #11
Conversation
eea9b79 to
43e186e
Compare
f4b4b51 to
55dabed
Compare
|
Was the target branch change intentional @tritao ? The diff is borked |
55dabed to
387719d
Compare
Not intentional, it got screwed up somehow, fixed now. |
387719d to
3419c65
Compare
|
it changed again @tritao :( |
|
Fixed again. |
3419c65 to
cb5f88d
Compare
055e2af to
81f03be
Compare
|
Thanks for the detailed review. I addressed the feedback as follows:
|
b3dd88a to
318d293
Compare
is this coin3d#641 or something else? I believe a merge of upstream |
| * Copyright (c) Kongsberg Oil & Gas Technologies AS | ||
| * All rights reserved. |
There was a problem hiding this comment.
As specified by Volker, you can drop this copyright in new files (or those completely modified like this one) and assign yourself or "FreeCAD contributors". Can you do a sweeping change on the PR stack?
| */ | ||
|
|
||
| /* This define is at least needed before inclusion of the header files | ||
| that are part of NVidia's Linux drivers v41.91. Without it, none of |
There was a problem hiding this comment.
what is this driver version? Looks old, nowadays we're in the 5XX range
| GL_GLEXT_VERSION: 20190326 | ||
| WGL_WGLEXT_VERSION: 20190228 |
There was a problem hiding this comment.
not sure why we use such an old commit. I was unable to find the exact commit hash where the files are imported from, 56a53de has a slightly different glcorearb.h. I think this is important for verification to easily match the imported headers' hashes against official headers.
| GL_GLEXT_VERSION: 20190326 | ||
| WGL_WGLEXT_VERSION: 20190228 | ||
| khrplatform.h semantic commit: | ||
| 67a3e0864c2d75ea5287b9f3d2eb74a745936692 |
There was a problem hiding this comment.
this is a 2017 commit, and the file at this commit is not the same as the one imported, which looks like a more recent version. It would be best to document the actual commit where this is from rather than the one presented as the 'semantic' one
|
You can freely merge once the last comments are addressed, it's mostly details, only gl headers import traceability is important to me. |
318d293 to
0670f86
Compare
Summary
Establish the profile-aware OpenGL header and build-configuration foundation used by the rest of the renderer stack.
Inventor/system/gl.has Coin's public OpenGL abstraction and isolate compatibility enum fallbacks ingl-fallbacks.h.COIN_HAVE_LEGACY_GL_RENDERERcapability separately from the build option.This layer establishes header and configuration policy only. It does not yet make LegacyGL traversal or implementation units optional.
Stack position
Bottom layer of this stack, based on
freecad-master.