Skip to content

feat: fraxtal assets#1

Merged
pegahcarter merged 7 commits into
init-repofrom
init-fraxtal
Sep 12, 2025
Merged

feat: fraxtal assets#1
pegahcarter merged 7 commits into
init-repofrom
init-fraxtal

Conversation

@pegahcarter
Copy link
Copy Markdown
Contributor

@pegahcarter pegahcarter commented Sep 3, 2025

Questions:

  • Should interfaces/ dir reside inside fraxtal/, within the respective token dir, somewhere else, or not at all?

Note that the contracts to be audited by Zellic are not yet included in this repo. I will be adding them separately post-audit once any necessary changes are applied.

Needs your approval here @tom2o17 @FortisFortuna

@pegahcarter pegahcarter changed the base branch from master to init-repo September 3, 2025 21:52
@pegahcarter pegahcarter marked this pull request as ready for review September 7, 2025 05:41
@FortisFortuna
Copy link
Copy Markdown

Questions:

  • Should interfaces/ dir reside inside fraxtal/, within the respective token dir, somewhere else, or not at all?

Note that the contracts to be audited by Zellic are not yet included in this repo. I will be adding them separately post-audit once any necessary changes are applied.

Needs your approval here @tom2o17 @FortisFortuna

I think if it is an unrelated "helper" interface for something external to the project (like IERC20) we can put it in the shared interfaces folder, but if it is an interface of something defined in the project, put it in that respective folder. Open to other suggestions.

@pegahcarter
Copy link
Copy Markdown
Contributor Author

pegahcarter commented Sep 11, 2025

I see what you're saying. Similar to OZ where there's contracts/token/ERC20/ERC20.sol and contracts/token/ERC20/IERC20.sol and a base interfaces/ dir with standalone interfaces. That makes sense. If @tom2o17 has no objections here I'll go with that.

@pegahcarter pegahcarter mentioned this pull request Sep 11, 2025
Copy link
Copy Markdown
Contributor

@tom2o17 tom2o17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Agree with the convention put forth by @FortisFortuna, for the interface convention

@pegahcarter pegahcarter merged commit 8bf6e67 into init-repo Sep 12, 2025
@pegahcarter pegahcarter deleted the init-fraxtal branch September 12, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants