You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Should interfaces/ dir reside inside fraxtal/, within the respective token dir, somewhere else, or not at all?
Note that the contracts to be audited by Zellic are not yet included in this repo. I will be adding them separately post-audit once any necessary changes are applied.
Should interfaces/ dir reside inside fraxtal/, within the respective token dir, somewhere else, or not at all?
Note that the contracts to be audited by Zellic are not yet included in this repo. I will be adding them separately post-audit once any necessary changes are applied.
I think if it is an unrelated "helper" interface for something external to the project (like IERC20) we can put it in the shared interfaces folder, but if it is an interface of something defined in the project, put it in that respective folder. Open to other suggestions.
I see what you're saying. Similar to OZ where there's contracts/token/ERC20/ERC20.sol and contracts/token/ERC20/IERC20.sol and a base interfaces/ dir with standalone interfaces. That makes sense. If @tom2o17 has no objections here I'll go with that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Questions:
interfaces/dir reside insidefraxtal/, within the respective token dir, somewhere else, or not at all?Note that the contracts to be audited by Zellic are not yet included in this repo. I will be adding them separately post-audit once any necessary changes are applied.
Needs your approval here @tom2o17 @FortisFortuna