tor: bind final SOCKS listener before publishing port (ENV-3071) - #81
Open
Jacksper13 wants to merge 1 commit into
Open
tor: bind final SOCKS listener before publishing port (ENV-3071)#81Jacksper13 wants to merge 1 commit into
Jacksper13 wants to merge 1 commit into
Conversation
Remove the reserve-close-rebind handoff from Dart. Let the native proxy select and retain its ephemeral listener, return the actual bound port, and fail closed if a requested port is already owned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dart reserved an ephemeral SOCKS port, closed the reservation, and then asked Rust to bind it. Another local process could claim that port during the handoff, and Envoy could report a port it did not own.
Changes
Validation
Stacked on #79 because it uses the synchronous listener startup introduced there. Tracks ENV-3071.