Skip to content

fix slider reversal#1723

Merged
joepavitt merged 2 commits into
mainfrom
1720-fix-slider-reversal
Jun 2, 2025
Merged

fix slider reversal#1723
joepavitt merged 2 commits into
mainfrom
1720-fix-slider-reversal

Conversation

@Steve-Mcl

Copy link
Copy Markdown
Contributor

closes #1720

Description

  • Ensure min and max (and step) values are numeric to avoid string comparison reversing slider
  • Update e2e tests and fixture (to cause reversal on old src) and ensure reversal is not present in updated src (regression avoidance).

Related Issue(s)

#1720

Checklist

  • I have read the contribution guidelines
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated
    • Upgrade instructions
    • Configuration details
    • Concepts
  • Changes flowforge.yml?
    • Issue/PR raised on FlowFuse/helm to update ConfigMap Template
    • Issue/PR raised on FlowFuse/CloudProject to update values for Staging/Production

Labels

  • Includes a DB migration? -> add the area:migration label

@Steve-Mcl Steve-Mcl requested a review from joepavitt May 30, 2025 08:00
@joepavitt joepavitt merged commit c01bbad into main Jun 2, 2025
@joepavitt joepavitt deleted the 1720-fix-slider-reversal branch June 2, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slider is reversed with min 99 and max 320

2 participants