added arithmetic shift operations#47
Open
0xflotus wants to merge 5 commits intoFlorianWendelborn:mainfrom
Open
added arithmetic shift operations#470xflotus wants to merge 5 commits intoFlorianWendelborn:mainfrom
0xflotus wants to merge 5 commits intoFlorianWendelborn:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 45 +2
Lines 311 325 +14
Branches 49 49
=========================================
+ Hits 311 325 +14
Continue to review full report at Codecov.
|
Contributor
Author
|
oops, I swapped left shift with right shift. Fixed it a few minutes ago. |
Owner
|
@0xflotus I merged the circular shift one as it was obvious how it should behave on arbitrary lengths of bits (doesn’t modify length). However, I’m really not sure about this one and if it’s more reasonable to keep the length or to decrease/increase it by |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part 2 of fix #44