Skip to content

Select regressor beliefs per (event_start, regressor) in forecasting covariate assembly#2155

Draft
Copilot wants to merge 5 commits into
mainfrom
copilot/select-latest-regressor-beliefs
Draft

Select regressor beliefs per (event_start, regressor) in forecasting covariate assembly#2155
Copilot wants to merge 5 commits into
mainfrom
copilot/select-latest-regressor-beliefs

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

Forecast covariate preparation could drop valid regressor values when multiple regressors had beliefs for the same event_start at different belief_times. Selection was done per joined row (event_start), not per regressor, causing false missing data downstream.

  • Covariate selection logic

    • Added per-regressor selection in BasePipeline.split_data_all_beliefs via a helper that picks one value per (event_start, regressor).
    • Applied this consistently across:
      • past regressors (latest belief per event),
      • realized future regressors (closest realized belief per event),
      • forecast-window future regressors (latest admissible forecast belief per event).
    • This preserves independently known regressor values while still producing one wide covariate row per event_start.
  • Safety guard

    • Added explicit validation for selection mode (latest / closest) to prevent silent misuse.
  • Regression coverage

    • Added a focused test that reproduces mixed-belief-time regressor rows for the same event and asserts both regressor values are retained in the assembled future covariates.
# Before (row-level collapse):
event_start=10:00, belief_time=09:45, regressor_A=NaN, regressor_B=7.0

# After (per-regressor selection):
event_start=10:00, regressor_A=5.0, regressor_B=7.0

Copilot AI and others added 4 commits May 8, 2026 02:41
Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/c980e7ce-6145-48fd-a71b-cd845af19b4e

Co-authored-by: BelhsanHmida <149331360+BelhsanHmida@users.noreply.github.com>
Agent-Logs-Url: https://github.com/FlexMeasures/flexmeasures/sessions/c980e7ce-6145-48fd-a71b-cd845af19b4e

Co-authored-by: BelhsanHmida <149331360+BelhsanHmida@users.noreply.github.com>
Copilot AI changed the title [WIP] Select latest known regressor beliefs per regressor Select regressor beliefs per (event_start, regressor) in forecasting covariate assembly May 8, 2026
Copilot AI requested a review from BelhsanHmida May 8, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Select latest known regressor beliefs per regressor instead of per event_start row

2 participants