Skip to content

refactor: update GitHub installation completion message#7202

Open
mustafajw07 wants to merge 1 commit intoFlagsmith:mainfrom
mustafajw07:feature/7143-GitHub-integration-completion-page
Open

refactor: update GitHub installation completion message#7202
mustafajw07 wants to merge 1 commit intoFlagsmith:mainfrom
mustafajw07:feature/7143-GitHub-integration-completion-page

Conversation

@mustafajw07
Copy link
Copy Markdown

@mustafajw07 mustafajw07 commented Apr 10, 2026

Thanks for submitting a PR! Please check the boxes below:

  • I have read the Contributing Guide.
  • I have added information to docs/ if required so people know about the feature.
  • I have filled in the "Changes" section below.
  • I have filled in the "How did you test this code" section below.

Changes

Contributes to 7143
Updated the GitHub integration setup completion view in GitHubSetupPage to correctly match the required UI acceptance criteria:

  • Removed the old, un-styled <h1>Installation Completed</h1> layout.
  • Added the emphasised text: "GitHub installation completed!"
  • Added the smaller print optional text beneath it: "You may close this window."
  • Ensured the setup form inputs are properly hidden during the completion view.

How did you test this code?

Tested manually on the local frontend dev server:

  1. Ran the frontend via ENV=local npm run dev.
  2. Bypassed the OAuth flow by setting the success state in the browser DevTools console: localStorage.setItem('githubIntegrationSetupFromFlagsmith', 'install');
  3. Navigated directly to /github-setup.
  4. Visually verified that the empty layout rendered correctly with the new emphasised text and smaller-print sub-text.
  5. Ran frontend linting and typechecking successfully.

@mustafajw07 mustafajw07 requested a review from a team as a code owner April 10, 2026 10:42
@mustafajw07 mustafajw07 requested review from Zaimwa9 and removed request for a team April 10, 2026 10:42
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

@mustafajw07 is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Apr 10, 2026
@emyller
Copy link
Copy Markdown
Contributor

emyller commented Apr 10, 2026

@mustafajw07 Thanks for your contribution! I'm afraid, however, this patch does not meet the Acceptance Criteria specified in #7143 yet.

If you'd be so kind also, please add a screenshot to the PR description — that makes it easier to review! Note the window size of the screenshot, given this page opens as a small popup containing the GitHub OAuth flow (see issue examples).

@mustafajw07
Copy link
Copy Markdown
Author

containing

Apologies, i will take i look again.

@Zaimwa9 Zaimwa9 self-requested a review April 13, 2026 15:50
Copy link
Copy Markdown
Contributor

@Zaimwa9 Zaimwa9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing my approval after reading the threads, my bad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

front-end Issue related to the React Front End Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants