WIP: Reworked Target System and Toplevel Capture#70
Draft
Conversation
Owner
Author
|
This was an ugly refactor, wl-mirror definitely needs to be changed to be less coupled between files, and needs to make less assumptions. Hopefully once this PR is finished we'll have a better base to build future things off of. The current state introduces the indirection layer of an opaque After initial toplevel capture works the next step is to clean up leftover hacks and fix regressions around region handling. Finally, document the resulting design before merging. |
0a71c90 to
25d2b10
Compare
70dfbcb to
be1ff17
Compare
be1ff17 to
9b89add
Compare
9b89add to
0d3e6f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP PR for implementing non-wl_output target support and toplevel capture, among other things.
Related Issues:
Current State:
mirror/target.cgeneric mirror target typeoptions.cchanges:mirror/target.c)wayland.cchanges:output_list_node_thandling inwayland.cwayland.cegl.cchanges