Skip to content

WIP: Reworked Target System and Toplevel Capture#70

Draft
Ferdi265 wants to merge 2 commits intomainfrom
feature-toplevel-capture
Draft

WIP: Reworked Target System and Toplevel Capture#70
Ferdi265 wants to merge 2 commits intomainfrom
feature-toplevel-capture

Conversation

@Ferdi265
Copy link
Copy Markdown
Owner

@Ferdi265 Ferdi265 commented Jun 16, 2025

WIP PR for implementing non-wl_output target support and toplevel capture, among other things.

Related Issues:

Current State:

  • mirror/target.c generic mirror target type
    • Output Targets
      • output name matching on make/model is partially implemented (wlr output management protocol not used yet, so doesn't work on wlroots since it advertises "Unknown Unknown" for every output in wl_output)
    • Toplevel Targets
  • options.c changes:
    • Refactor output and region finding code (potentially move to mirror/target.c)
  • wayland.c changes:
    • Refactor output_list_node_t handling in wayland.c
    • Add toplevel list handling to wayland.c
  • egl.c changes
    • Remove wl_output specific hacks

@Ferdi265
Copy link
Copy Markdown
Owner Author

Ferdi265 commented Jun 16, 2025

This was an ugly refactor, wl-mirror definitely needs to be changed to be less coupled between files, and needs to make less assumptions. Hopefully once this PR is finished we'll have a better base to build future things off of.

The current state introduces the indirection layer of an opaque wlm_mirror_target_t type that is used to represent a target. The next step is to implement toplevel listing and adjust CLI parsing to actually create the correct type of target.

After initial toplevel capture works the next step is to clean up leftover hacks and fix regressions around region handling.

Finally, document the resulting design before merging.

@Ferdi265 Ferdi265 force-pushed the feature-toplevel-capture branch from 0a71c90 to 25d2b10 Compare June 23, 2025 11:35
@Ferdi265 Ferdi265 force-pushed the feature-toplevel-capture branch 2 times, most recently from 70dfbcb to be1ff17 Compare July 27, 2025 20:49
@Ferdi265 Ferdi265 force-pushed the feature-toplevel-capture branch from be1ff17 to 9b89add Compare February 8, 2026 19:24
@Ferdi265 Ferdi265 force-pushed the feature-toplevel-capture branch from 9b89add to 0d3e6f2 Compare February 9, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant