fix: zsh-completions fails when no outputs are found#66
Open
mazunki wants to merge 4 commits intoFerdi265:mainfrom
Open
fix: zsh-completions fails when no outputs are found#66mazunki wants to merge 4 commits intoFerdi265:mainfrom
mazunki wants to merge 4 commits intoFerdi265:mainfrom
Conversation
Owner
|
Ah, sorry for that, I don't use zsh personally, and I must have missed this during my testing. Will look at this in the coming days. |
Contributor
Author
|
No biggie, it wasn't meant as a blame :) |
Ferdi265
requested changes
Apr 7, 2025
Owner
Ferdi265
left a comment
Ferdi265
left a comment
There was a problem hiding this comment.
Added some review comments about the warning message and the way that missing outputs are checked for.
Contributor
Author
|
Hm, actually, I'm not sure if this is specific to my system, but I'm not receiving the inner messages. Perhaps i should move the check for valid values of the variables outside. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_valuesneeds a non-empty value passed to it. Your change caused the completion to error on my system, since myXDG_CURRENT_DESKTOPwas not set.This PR changes this situation to a gracious warning instead. Is the same fix necessary on bash?