Added filtering by window title regex to blacklist and whitelist - #183
Open
olegtarasov wants to merge 5 commits into
Open
olegtarasov wants to merge 5 commits into
olegtarasov wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full disclosure: I vibecoded this feature with Codex from OpenAI.
I encountered a problem while using JankyBorders with JetBrains IDEs: tooltips windows get a border. This is not a desired behavior for me, especially when hovering on filenames in project explorer:
So I really needed some kind of way to blacklist only certain windows, not the entire app. Filtering by window title regex looks like a solution to this problem, so I tried to add this feature while preserving backward compatibility.
Now several rules can be specified for both
blacklistandwhitelist. If there is only the app name, the filter behaves like before. But you can also specify multiple rules for a single app with additional regex filters for window title, like this:borders style=round width=10 hidpi=on active_color=0xffd36151 inactive_color=0x00000000 blacklist="clion:^$"This example fixes the problem that I had with JetBrains IDEs:
EDIT: After completing the PR, I looked at other PRs in this repo and found another solution for JetBrains IDEs :) Well, regex filtering still looks like a useful feature, so I'll leave my PR for your consideration as well.