Skip to content

[OoT] fix scene_table.h parsing empty lines #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dragorn421 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[OoT] fix scene_table.h parsing empty lines #710

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6184b6
[OoT] fix scene_table.h parsing empty lines
Dragorn421 May 29, 2026
6eb97aa
also show the line SceneTableEntry.from_line chokes on
Dragorn421 May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fast64_internal/z64/exporter/decomp_edit/scene_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def from_line(original_line: str):

return SceneTableEntry(*params)
else:
raise PluginError("ERROR: This line is not a scene table entry!")
raise PluginError("ERROR: This line is not a scene table entry! " + repr(original_line))

@staticmethod
def from_scene(scene_name: str, draw_config: str, title_card_name: str):
Expand Down Expand Up @@ -119,8 +119,8 @@ def new(export_path: str):
header = data[: header_end_index + 1]

lines = data[header_end_index + 1 :].split("\n")
lines = list(filter(None, lines)) # removes empty lines
lines = [line.strip() for line in lines]
lines = list(filter(None, lines)) # removes empty lines

sections: list[SceneTableSection] = []
current_section: Optional[SceneTableSection] = None
Expand Down