Skip to content

added underlines to links in footer and refactored code in footer.js #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samhstn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added underlines to links in footer and refactored code in footer.js #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions frontend/src/css/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ body {
margin: auto;
}

.footer-top ul:nth-child(1) li:nth-child(2), .footer-top ul li:nth-child(5), .footer-top div:nth-child(2) ul li:nth-child(1), .footer-top ul:nth-child(2) li:nth-child(2) {
text-decoration: underline;
}

footer {
background-color: #222e3e;
color: #fff;
Expand Down
7 changes: 0 additions & 7 deletions frontend/src/js/footer/footer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,37 +22,30 @@ class Footer extends React.Component {

var contactContent = [
{
id: 'a',
content: 'FOUNDERS & CODERS'
},
{
id: 'b',
link: 'http://foundersandcoders.com',
content: 'foundersandcoders.com'
},
{
id: 'c',
content: 'hello@foundersandcoders.com'
},
{
id: 'd',
content: '+44 20 3583 2442'
},
{
id: 'e',
link: 'https://www.google.co.uk/maps/place/14+Palmers+Rd,+London+E2+0SY/@51.5295351,-0.0444836,17z/data=!3m1!4b1!4m2!3m1!1s0x48761d26bfacb2ab:0xf4a25d562f22b01b',
content: '14 Palmers Road, London, E2 0SY'
}
]

var aboutContent = [
{
id: 'f',
content: 'GitHub Repo',
link: 'https://github.com/FAC7/amazon2.0'
},
{
id: 'g',
content: 'Issues',
link: 'https://github.com/FAC7/amazon2.0/issues'
}
Expand Down
5 changes: 3 additions & 2 deletions frontend/src/js/footer/topFooter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class TopFooter extends React.Component {
<h3>{this.props.heading}</h3>
<ul style={ulStyles}>
{this.props.data.map((item) => {
return <li key={item.id} ><a href={item.link}>{item.content}</a></li>
return <li><a target='_blank' href={item.link}>{item.content}</a></li>
})}
</ul>
</div>
Expand All @@ -29,7 +29,8 @@ var ulStyles = {
TopFooter.propTypes = {
heading: React.PropTypes.string.isRequired,
data: React.PropTypes.arrayOf(React.PropTypes.objectOf(React.PropTypes.string)).isRequired,
width: React.PropTypes.string
width: React.PropTypes.string,
marginRight: React.PropTypes.string
}

export default TopFooter