Skip to content

[No QA] Docs updates for E/A#96407 Document importing merchant rules via spreadsheet#96544

Merged
stephanieelliott merged 4 commits into
mainfrom
claude-docsImportMerchantRules96407
Jul 23, 2026
Merged

[No QA] Docs updates for E/A#96407 Document importing merchant rules via spreadsheet#96544
stephanieelliott merged 4 commits into
mainfrom
claude-docsImportMerchantRules96407

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Summary

Adds a new help site article documenting how Workspace Admins import Merchant Rules using a spreadsheet, and how Tag cells are interpreted for single-level vs. multi-level tags.

This is the docs counterpart to #96407, which fixed how a X: Y Tag cell is normalized during merchant rule import. The spreadsheet-import flow (and the tag-interpretation behavior that PR touches) was previously undocumented — the existing Merchant Rules article only covers creating rules manually.

What's added

New article docs/articles/new-expensify/workspaces/Import-Merchant-Rules.md covering:

  • Who can import Merchant Rules — Workspace Admin on a workspace with Rules enabled (Control plan).
  • How to import Merchant Rules using a spreadsheet — the exact flow: Workspaces > [workspace] > Rules > More > Import merchant rules, map columns (Merchant is / Merchant contains plus a field to update like Updated tag), then Import.
  • How Tag values are interpreted — on multi-level-tag workspaces a colon separates levels (Parent: Child → Level1 Parent, Level2 Child, spaces trimmed); on single-level tag lists a colon stays part of the tag name (ab:cd → one tag ab:cd). This documents the behavior fixed in [CP Staging] Fix imported merchant rule tag corruption for X: Y (multi-level) tag format #96407.
  • FAQ covering skipped rows and unexpected tag display.

UI label verification

All feature names, menu items, and buttons were verified against the current UI strings in src/languages/en.ts and rendered with exact casing: More, Import merchant rules, Merchant is, Merchant contains, Updated merchant, Updated category, Updated tag, Updated description, Import, and the Rules page.

Authoring compliance

Follows docs/TEMPLATE.md, docs/HELP_AUTHORING_GUIDELINES.md, and docs/HELPSITE_NAMING_CONVENTIONS.md: single primary workflow, one # title, task-based ## headings, verified UI labels in Sentence case, relative cross-links placed outside numbered steps.


@NicolasBonet, please review the files changed and confirm they reflect the current behavior. Then mark this PR Ready for review.

Co-authored-by: Nicolás Bonet <NicolasBonet@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jul 21, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#96407 Document importing merchant rules via spreadsheet [No QA] Docs updates for E/A#96407 Document importing merchant rules via spreadsheet Jul 21, 2026
@OSBotify

This comment has been minimized.

NicolasBonet
NicolasBonet previously approved these changes Jul 21, 2026
@NicolasBonet
NicolasBonet marked this pull request as ready for review July 21, 2026 14:54
Comment thread docs/articles/new-expensify/workspaces/Import-Merchant-Rules.md Outdated
Comment thread docs/articles/new-expensify/workspaces/Import-Merchant-Rules.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single new article, docs/articles/new-expensify/workspaces/Import-Merchant-Rules.md, documenting how Workspace Admins bulk-create Merchant Rules via spreadsheet import and how Tag cells are interpreted for single-level vs. multi-level tags. It is the docs counterpart to #96407. The article is well-scoped to one primary workflow and closely follows the governance files. All 75 added lines are net-new content.

Scores Summary

  • Readability: 9/10 - Clear, concise prose with sequential numbered steps, well-formatted bullets, and concrete examples (Parent: Child, ab:cd). Scannable and benefit-focused intro.
  • AI Readiness: 9/10 - Complete YAML frontmatter including internalScope with audience/covers/does-not-cover; task-based headings; multiple How to headings using the full feature name; strict heading hierarchy (single title plus exempt FAQ); realistic keywords matching search intent.
  • Style Compliance: 9/10 - UI labels bolded in Sentence case and verified against en.ts (More, Import merchant rules, Merchant is, Merchant contains, Updated tag, Import, Rules); FAQ uses question-style headings; relative cross-links placed outside numbered steps; mobile availability stated; screenshot placeholder uses correct non-rendered HTML comment format with a specific Purpose.

Key Findings

  • Strong governance adherence: exactly one title heading, task-based section headings, no generic/noun-only headings, single workflow, at least one How to heading, and a compliant internalScope.
  • Cross-links verified: the Workspace-Rules#enable-workspace-rules link resolves to the existing "How to enable Workspace Rules" heading, and Create-and-manage-expense-tags exists. Links are descriptive and outside step flow.
  • Minor navigation phrasing nit: Step 1 uses "In the navigation tabs (on the left on web, and at the bottom on mobile)". The convention example reads "(on the left on web, on the bottom on mobile)" without the inserted "and" / "at the". Not a blocker, but align for exact consistency.
  • Minor terminology consistency: the article mixes "merchant rule field" (lowercase) with the capitalized feature name "Merchant Rules". Consider consistent casing when referring to the feature.
  • FAQ heading "Can I import Merchant Rules on mobile?" is answered well, but per the mobile-availability convention consider stating the limitation more directly if import truly is not supported on mobile (current wording implies web is merely "best experience").

Recommendations

  • Align Step 1 navigation phrasing with the exact convention wording: "(on the left on web, on the bottom on mobile)".
  • Standardize feature-name casing ("Merchant Rules" as the feature; lowercase only for generic references).
  • Clarify the mobile FAQ answer to explicitly state whether import is unsupported vs. simply not recommended on mobile.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Import-Merchant-Rules.md (new) - Compliant, high quality; only minor phrasing/casing polish suggested.

Note: Detailed line-by-line feedback has been provided as inline comments.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e08924eca3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/articles/new-expensify/workspaces/Import-Merchant-Rules.md Outdated
@OSBotify

This comment has been minimized.

NicolasBonet
NicolasBonet previously approved these changes Jul 22, 2026
@OSBotify

This comment has been minimized.

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://94f274a2.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott
stephanieelliott merged commit 4bb1d01 into main Jul 23, 2026
16 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsImportMerchantRules96407 branch July 23, 2026 01:18
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.4.44-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants