86919: Message in IOU is not scrolled to when navigating via link, 'submitted' not shown#96428
Draft
abbasifaizan70 wants to merge 6 commits into
Draft
86919: Message in IOU is not scrolled to when navigating via link, 'submitted' not shown#96428abbasifaizan70 wants to merge 6 commits into
abbasifaizan70 wants to merge 6 commits into
Conversation
…ubmitted' not shown
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Open
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This fixes the copied message link for one-transaction expenses. Previously the link pointed at the transaction thread, so opening it hid the parent "Submitted" system message and failed to scroll to the linked message. The copy-link action now uses the displayed (parent expense) report ID; LinkedActionNotFoundGuard also looks up the linked action in the transaction thread so a valid link no longer renders "comment not found"; and usePaginatedReportActions falls back to the newest window instead of an empty list when the linked action belongs to the merged-in thread. Result: the link opens the combined expense view with "Submitted" visible and scrolls to the linked message on first navigation.
Fixed Issues
$ #86919
PROPOSAL: #86919 (comment)
Tests
Steps:
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-07-18.at.3.37.35.AM.mov
Android: mWeb Chrome
Screen.Recording.2026-07-18.at.3.42.06.AM.mp4
iOS: Native
Screen.Recording.2026-07-18.at.2.58.01.AM.mov
Screen.Recording.2026-07-18.at.2.59.07.AM.mov
iOS: mWeb Safari
Screen.Recording.2026-07-18.at.3.02.19.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-07-18.at.2.52.35.AM.mov