Skip to content

Render the 30-day broken card connection messages#96409

Draft
allgandalf wants to merge 7 commits into
Expensify:mainfrom
allgandalf:card-connection-broken-30-day-reminder
Draft

Render the 30-day broken card connection messages#96409
allgandalf wants to merge 7 commits into
Expensify:mainfrom
allgandalf:card-connection-broken-30-day-reminder

Conversation

@allgandalf

@allgandalf allgandalf commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Frontend rendering for two new report actions the backend posts 30 days after a card connection breaks (if it's still broken): COMPANYCARDCONNECTIONBROKEN30DAYS (workspace #admins room) and PERSONALCARDCONNECTIONBROKEN30DAYS (Concierge DM). They render like the existing broken-connection actions (a muted system message with an inline "Log into your bank" link) but with copy that says the connection has been broken for 30 days and offers to remove the card/connection.

Opening as a draft: these actions only appear once the backend (Auth + Web-Expensify) ships, so this rides behind those PRs.

Backend plan: https://github.com/Expensify/Expensify/issues/658860
Auth PR: https://github.com/Expensify/Auth/pull/23010
Web-Expensify PR: https://github.com/Expensify/Web-Expensify/pull/54641

Fixed Issues

$ #88240
PROPOSAL: N/A (assigned engineering task, backend-driven)

Tests

  1. Open a workspace #admins room with a COMPANYCARDCONNECTIONBROKEN30DAYS action and verify it renders "The {feed} connection has been broken for 30 days. Log into your bank to fix it or remove the connection if it's no longer in use. You won't lose any submitted expenses if you remove it." with a tappable "Log into your bank" link to the workspace company cards page.
  2. Open a Concierge DM with a PERSONALCARDCONNECTIONBROKEN30DAYS action and verify it renders "Your {card} connection has been broken for 30 days. Log into your bank to fix it or remove the card if it's no longer in use. You won't lose any submitted expenses if you remove it." with a tappable link to the personal card details page (when the card is still broken).
  3. Verify no errors appear in the JS console.
  • Verify that no errors appear in the JS console

Offline tests

  1. Go offline.
  2. Open a report containing either new action and verify the message still renders from cached Onyx data (plain system message, no network needed).

QA Steps

  1. Open a workspace #admins room with a company feed broken for 30 days and verify the reminder message and its "Log into your bank" link.
  2. Open a Concierge DM for a personal card broken for 30 days and verify the reminder message and its link.
  3. Verify no errors appear in the JS console.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@melvin-bot

melvin-bot Bot commented Jul 17, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/CONST/index.ts 94.81% <ø> (ø)
src/libs/ReportActionsUtils.ts 78.52% <100.00%> (+0.08%) ⬆️
src/libs/ReportNameUtils.ts 82.05% <100.00%> (+0.08%) ⬆️
...nbox/report/actionContents/ActionContentRouter.tsx 93.78% <100.00%> (+0.15%) ⬆️
...ort/actionContents/CardBrokenConnectionContent.tsx 100.00% <100.00%> (ø)
src/libs/SidebarUtils.ts 80.29% <50.00%> (-0.10%) ⬇️
...es/inbox/report/ContextMenu/ContextMenuActions.tsx 21.78% <0.00%> (-0.07%) ⬇️
... and 25 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant