feat: derive app-load skeleton gates from the request queue

[BartekObudzinski]

Explanation of Change

Several full-page and skeleton loaders decide whether the app is still doing its initial load by reading the stored IS_LOADING_APP Onyx flag. That flag is a shadow of the request queue: it is set optimistically when the initial OpenApp request is enqueued and cleared when the request leaves the queue, but a reload or dropped response in between can strand it, leaving the loader up forever with no request running.

This change moves those consumers onto the queue-derived useIsAppLoadPending() hook, which reads directly whether an OpenApp request is currently in the SequentialQueue. The flag was already set and cleared atomically with that request, so healthy-path behavior is identical — the only difference is that a stranded flag can no longer pin a loader.

Scope is the consumers that read the flag as a plain loading gate. Consumers with different semantics (a true/false default that treats "unknown" as loading, completion checks, latches, or non-loader logic) are intentionally left on the flag. The flag, its writers, and the recovery watchdog are untouched — their removal is a separate change. Telemetry reasonAttributes keep their existing isLoadingApp key name (now sourced from the hook) for continuity in Sentry.

Migrated: WorkspaceSelector, DomainsListPage, DynamicNewReportWorkspaceSelectionPage, DynamicReportChangeWorkspacePage, SetDefaultWorkspacePage, ReportActions, MoneyRequestReportView, useReportActionsListModel, ProfilePage, WalletPage.

Fixed Issues

$
PROPOSAL:

Tests

1. Cold-start the app. Verify the initial full-page / skeleton loaders show, then the content renders.
2. Open each migrated screen (Profile, Wallet, Domains list, a workspace selector) during and after the initial load. Verify no endless loader.
3. Reload the app mid initial-load, then reopen a migrated screen. Verify the loader resolves once OpenApp completes (no stuck loader).

• Verify that no errors appear in the JS console

Offline tests

1. Go offline, then open the migrated screens. Verify they do not sit on an endless skeleton and offline handling matches today.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
.../MoneyRequestReportView/MoneyRequestReportView.tsx	54.94% <100.00%> (ø)
...ents/Search/FilterComponents/WorkspaceSelector.tsx	89.65% <100.00%> (ø)
src/hooks/useReportActionsListModel.ts	100.00% <100.00%> (ø)
...c/pages/DynamicNewReportWorkspaceSelectionPage.tsx	85.85% <100.00%> (ø)
src/pages/inbox/ReportActions.tsx	100.00% <100.00%> (ø)
src/pages/settings/Profile/ProfilePage.tsx	95.09% <100.00%> (-0.05%)	⬇️
src/pages/DynamicReportChangeWorkspacePage.tsx	0.00% <0.00%> (ø)
src/pages/SetDefaultWorkspacePage.tsx	0.00% <0.00%> (ø)
src/pages/domain/DomainsListPage.tsx	0.00% <0.00%> (ø)
src/pages/settings/Wallet/WalletPage/index.tsx	0.00% <0.00%> (ø)
... and 30 files with indirect coverage changes