[Part 1] Remove Onyx.connect(ONYXKEYS.SESSION) in /Session/index.ts: thread sesion through isSupportAuthToken

[truph01]

Explanation of Change

• isSupportAuthToken — Renamed the module-level session variable to deprecatedSession. Added a session parameter to isSupportAuthToken with a fallback to deprecatedSession for unrefactored callers. Updated InitialSettingsPage.tsx to pass session from its existing useOnyx subscription.

• isSupportAuthToken → shouldInitialize (Fullstory) — Threaded session through the full Fullstory chain: init → consentAndIdentify → shouldInitialize → isSupportAuthToken. Made session a required parameter across all Fullstory types and both platform implementations. Updated FullstoryInitHandler.tsx to subscribe to ONYXKEYS.SESSION via useOnyx and pass it down. Added a dedicated fullstorySession variable via connectWithoutView for the Onyx callback path, avoiding use of deprecatedSession.

Fixed Issues

$ #67782
PROPOSAL:

Tests

1. Login to ND
2. Open Account tab
3. Verify the "Sign out" button is shown

• Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include ""[No QA].""
Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained ""why"" the code was doing something instead of only explaining ""what"" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named ""index.js"". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-07-17.at.10.37.05.mov

[melvin-bot]

@shubham1206agra @DylanDylann One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[github-actions]

This PR adds a new Onyx.connectWithoutView call, so I've requested a review from the Onyx performance reviewers (@tgolen, @mountiny, @luacmartins) — a review from any one of them is enough. Please add a link in your PR description to the Slack discussion where the @frontend-performance team approved using connectWithoutView here.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d2c751e11b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/FullstoryInitHandler.tsx	87.50% <100.00%> (+1.78%)	⬆️
src/pages/settings/InitialSettingsPage.tsx	85.40% <100.00%> (ø)
src/libs/Fullstory/index.native.ts	0.00% <0.00%> (ø)
src/libs/actions/Session/index.ts	42.52% <82.35%> (-0.13%)	⬇️
src/libs/Fullstory/index.ts	0.00% <0.00%> (ø)
... and 12 files with indirect coverage changes

[trjExpensify]

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

[tgolen]

I'd really love for all the full story stuff to exist in its own module. That will also help isolate the connectWithoutView() calls a bit more. Would you mind doing the small refactor? I'm not sure how much it would involve, so we could do that in a separate issue if it's too much.

[truph01]

@MelvinBot, give me plan to do it

[truph01]

@tgolen Resolved via fc0285b

[MelvinBot]

Here's a plan to finish the job this PR starts — fully removing the module-level Onyx.connect(ONYXKEYS.SESSION) at src/libs/actions/Session/index.ts:92 that populates deprecatedSession.

Goal: every read of deprecatedSession disappears, so the Onyx.connect block that feeds it can be deleted. Same TDD flow the issue asks for (unit test → refactor → verify), one small PR per group so each stays reviewable.

Remaining deprecatedSession consumers, grouped by difficulty:

Group A — pure read helpers (easy, same pattern as Part 1: add a session param, thread it from the caller's useOnyx):

• isSupportalSession() — L154 (isSupportAuthTokenUsed)
• isAnonymousUser() — L315 (already takes sessionParam; just drop the deprecatedSession fallback and make callers pass it)
• hasAuthToken() — L326

Group B — imperative call-time reads inside signOutAndRedirectToSignIn/stash logic. These run in response to a user action, so the cleanest fix is to read the current session once via Onyx.connect's replacement — an await OnyxUtils.get(ONYXKEYS.SESSION) (or thread it in from the calling component) at the top of the function and pass it down:

• signOut args — L388 (signedInWithSAML, authToken)
• STASHED_SESSION: deprecatedSession — L401 and L729
• accountID — L423
• anonymous-account cleanup — L630-631

Group C — genuinely reactive uses. These fire on session change inside the Onyx.connect callback, so they can't just take a param — this is the last group and the one to think hardest about:

• waitForUserSignIn() / authPromiseResolver — L1462 resolves a promise when authToken becomes truthy via the callback at L100.
• creationDate defaulting (L97-99) — this actually writes a default back into the in-memory session; needs to move to wherever the session is first written, not a subscription.
• HybridApp sendAuthToken on auth-token arrival (L104-105).

Suggested PR sequence:

1. Part 2 — Group A (three read helpers + their callers).
2. Part 3 — Group B (signOut/stash path; scope it to that one function tree).
3. Part 4 — Group C, the reactive bits. Options: move the auth-token/HybridApp side effects into a small handler component that subscribes with useOnyx + useEffect (mirrors what Part 1 did for Fullstory), and convert waitForUserSignIn to resolve off that same subscription. Get frontend-performance sign-off if you keep any connectWithoutView here.
4. Final — once no deprecatedSession reads remain, delete let deprecatedSession and the Onyx.connect(ONYXKEYS.SESSION) block at L92-108.

Notes:

• Per group, write the unit test first against current behavior, refactor, confirm it still passes — then add functional + QA steps as the issue requires.
• The issue's step about decrementing an ESLint warning count in package.json#L48 looks stale — the repo now grandfathers these via eslint-seatbelt, so the count drops automatically as each Onyx.connect is removed. Run npm run lint-changed and update the seatbelt file if it prompts, rather than hand-editing a number.
• Leave the two connectWithoutView(ONYXKEYS.SESSION) calls (L112, L118) out of scope — the issue targets Onyx.connect, and those are the intentionally-approved Fullstory path from this PR.

[truph01]

@codex review

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: fc0285b163

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".