Add initial LitVM testnet config.#21
Conversation
This is the assumed URL based on the formatting of other networks.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new Nitro chain configuration file for the liteforge testnet. The review identified several critical issues, including a syntax error caused by a missing comma, a mismatch between the parent chain ID and the provided connection URLs, and multiple configuration values that violate the repository's validation scripts, such as incorrect placeholder strings and missing required sections.
| "url": [ | ||
| "wss://liteforge.rpc.caldera.xyz/feed" | ||
| ] | ||
| } |
There was a problem hiding this comment.
The JSON is invalid due to a missing comma after the input object. This will cause parsing errors.
| } | |
| }, |
| @@ -0,0 +1,126 @@ | |||
| { | |||
| "chain": { | |||
| "info-json": "[{\"chain-id\":4441,\"parent-chain-id\":11155111,\"chain-name\":\"liteforge\",\"chain-config\":{\"chainId\":4441,\"homesteadBlock\":0,\"daoForkBlock\":null,\"daoForkSupport\":true,\"eip150Block\":0,\"eip150Hash\":\"0x0000000000000000000000000000000000000000000000000000000000000000\",\"eip155Block\":0,\"eip158Block\":0,\"byzantiumBlock\":0,\"constantinopleBlock\":0,\"petersburgBlock\":0,\"istanbulBlock\":0,\"muirGlacierBlock\":0,\"berlinBlock\":0,\"londonBlock\":0,\"clique\":{\"period\":0,\"epoch\":0},\"arbitrum\":{\"EnableArbOS\":true,\"AllowDebugPrecompiles\":false,\"DataAvailabilityCommittee\":true,\"InitialArbOSVersion\":40,\"Celestia\":false,\"EigenDA\":false,\"InitialChainOwner\":\"0x8f0ad0fbc9e7e892fc951dfca366c588eebff883\",\"GenesisBlockNum\":0}},\"rollup\":{\"bridge\":\"0x9BC68f8B2fEa572eDc0813F76C186A31E4150F6F\",\"inbox\":\"0x8A381f8822E512E50dd4679E678271E9a83226E6\",\"sequencer-inbox\":\"0x7e8B0DD71be6C1216fd7334E7e5EAE8aa2e7276B\",\"rollup\":\"0xD8c594652B205fa4c8047608FAc3ab102B6e968d\",\"validator-utils\":\"0xd9F00104B2441f6fEe7780a88a4510dB693EC659\",\"validator-wallet-creator\":\"0x59caB1B944810B3c46bF154ca6E1dC96600C8c4b\",\"deployed-at\":10483581}}]", | |||
There was a problem hiding this comment.
The parent-chain-id inside the info-json string is set to 11155111 (Ethereum Sepolia), but the connection URLs at lines 44 and 112 point to 421614 (Arbitrum Sepolia). This mismatch will likely cause issues as the node will attempt to verify state against the wrong parent chain. Please update the info-json string to use 421614.
| }, | ||
| "node": { | ||
| "batch-poster": { | ||
| "enable": false, |
There was a problem hiding this comment.
The validation script scripts/validate_config.py (lines 216-221) requires the batch poster to be enabled. Since the PR description mentions this config is intended for use in the batcher, this should be set to true.
"enable": true,| "parent-chain-node-url": "http://erpc.mainnets.espresso.private:4000/main/evm/421614", | ||
| "rest-aggregator": { | ||
| "enable": true, | ||
| "urls": "PLACE_HOLDER" |
There was a problem hiding this comment.
The placeholder string should be PLACEHOLDER (without the underscore) to be compatible with the repository's validation scripts (scripts/validate_config.py and scripts/check_config.py).
"urls": "PLACEHOLDER"| }, | ||
| "rpc-aggregator": { | ||
| "assumed-honest": 1, | ||
| "backends": "PLACE_HOLDER", |
There was a problem hiding this comment.
The placeholder string should be PLACEHOLDER to match the expected value in the validation scripts.
"backends": "PLACEHOLDER",| "rpc-aggregator": { | ||
| "assumed-honest": 1, | ||
| "backends": "PLACE_HOLDER", | ||
| "enable": false |
There was a problem hiding this comment.
The validation script scripts/validate_config.py (lines 324-329) requires the RPC aggregator to be enabled when the section is present.
"enable": true| "txpool" | ||
| ], | ||
| "port": 8546 | ||
| } |
There was a problem hiding this comment.
The persistent section is missing, which is required by the validation script scripts/validate_config.py (line 151).
},
"persistent": {
"chain": "local"
}1 participant
Closes #TBD LitVM Testnet deployment (I will put a ticket here later, I'm just getting this up so we can have a config to run in the batcher in case we need to sync the chain state.
This PR:
Adds an initial config for the LitVM Testnet deployment.
This PR is not complete as some URL's are missing or assumed to be correct, but not confirmed.
This PR does not:
Add DA URL or Rest aggregator URL.
Key places to review: