Skip to content

Add appchain-mainnet batch poster config#15

Open
zacshowa wants to merge 1 commit into
mainfrom
zs/appchain-aws-migration
Open

Add appchain-mainnet batch poster config#15
zacshowa wants to merge 1 commit into
mainfrom
zs/appchain-aws-migration

Conversation

@zacshowa
Copy link
Copy Markdown
Contributor

Closes:

Issue #14

Asana task: Create Appchain config

This PR:

Adds the initial config to transition Appchain mainnet from SGX to AWS Nitro

This PR does not:

Lock the batch posters config.

Key places to review:

All files.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new configuration file for the Nitro appchain on mainnet. The feedback highlights a potential latency issue where enabling wait-for-max-delay alongside a 5-hour max-delay could significantly delay L1 finality for transactions. Additionally, the persistent.chain value should be corrected to "local" to comply with the project's configuration validation rules and avoid CI failures.

},
"poll-interval": "60s",
"post-4844-blobs": false,
"wait-for-max-delay": true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Setting wait-for-max-delay to true in conjunction with a max-delay of 5h0m0s (line 35) means the batch poster will wait for the full 5-hour window before posting to the parent chain, unless the max-size is reached first. For a mainnet deployment, this could result in very high latency for L1 finality of transactions during periods of low activity. Consider if this should be set to false (as seen in molten-mainnet.json) to allow more frequent postings when data is available.

}
},
"persistent": {
"chain": "local/appchain"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The persistent.chain value is set to "local/appchain". However, the configuration validator in scripts/validate_config.py (lines 166-173) explicitly checks that this value is set to "local" (unless an exception is defined in validation_exceptions.json). This will likely cause the validation script to fail in CI.

Suggested change
"chain": "local/appchain"
"chain": "local"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant