Add rufus-mainnet config file#13
Conversation
zacshowa
requested review from
Ancient123,
Sneh1999,
babdor,
jjeangal,
lukeiannucci and
varun-doshi
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the rufus-mainnet.json configuration file for the Nitro chain. The review feedback identifies several instances where the placeholder string PLACE_HOLDER is used incorrectly; these should be updated to PLACEHOLDER to ensure compatibility with the project's configuration validation scripts.
| "max-delay": "1h0m0s", | ||
| "max-size": 90000, | ||
| "parent-chain-wallet": { | ||
| "private-key": "PLACE_HOLDER" |
There was a problem hiding this comment.
The placeholder for the private key should be PLACEHOLDER to match the constant defined in scripts/validate_config.py. Using PLACE_HOLDER (with an underscore) will cause the validation script to fail at line 192.
| "private-key": "PLACE_HOLDER" | |
| "private-key": "PLACEHOLDER" |
| "parent-chain-node-url": "http://erpc.mainnets.espresso.private:4000/main/evm/1", | ||
| "rest-aggregator": { | ||
| "enable": true, | ||
| "urls": "PLACE_HOLDER" |
There was a problem hiding this comment.
The placeholder for the REST aggregator URLs should be PLACEHOLDER. The current value PLACE_HOLDER will fail the _is_placeholder check in scripts/validate_config.py (line 312).
| "urls": "PLACE_HOLDER" | |
| "urls": "PLACEHOLDER" |
| }, | ||
| "rpc-aggregator": { | ||
| "assumed-honest": 1, | ||
| "backends": "PLACE_HOLDER", |
There was a problem hiding this comment.
The placeholder for the RPC aggregator backends should be PLACEHOLDER to align with the validation rules in scripts/validate_config.py (line 335).
"backends": "PLACEHOLDER"
| }, | ||
| "espresso": { | ||
| "batch-poster": { | ||
| "attestation-service-url": "http://arb-verifier.mainnets.espresso.private:8080", |
There was a problem hiding this comment.
is arb-verifier correct? is it not eth-verifier or something?
There was a problem hiding this comment.
Good catch. I just have to trim off arb-
so it's just verifier.mainnets... for what we need.
2 participants
Closes:
Issue #12
Asana Task: Create Rufus mainnet config
This PR:
Adds a config for Rufus mainnet