Skip to content

Update OP Arg Passing#10

Open
jjeangal wants to merge 4 commits into
mainfrom
jg/updated-arg-passing
Open

Update OP Arg Passing#10
jjeangal wants to merge 4 commits into
mainfrom
jg/updated-arg-passing

Conversation

@jjeangal
Copy link
Copy Markdown
Member

@jjeangal jjeangal commented Apr 10, 2026

This PR:

  • Separates specific op batcher arguments to be later committed to the EIF enclave hash.
  • Leaves free batcher arguments passing at runtime without specifying them in the runtime eif file.
  • Allows to add and pass new arguments without creating a PR in this specific repository (e.g., Jovian Upgrade, etc.)

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the run-eif.sh script to enforce stricter environment variable requirements for the enclave batcher, categorizing parameters into required endpoints, committed parameters, and extra arguments. Several previously optional variables with defaults are now mandatory. Feedback was provided regarding the processing of EXTRA_ARGS, specifically recommending the use of set -f to prevent globbing issues during word splitting in the POSIX shell environment.

Comment thread aws-nitro/op/run-eif.sh
@jjeangal jjeangal self-assigned this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant