Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the README to document the project's branching strategy and release process for the main, release-mainnet, and release-decaf branches. The review feedback suggests using a more contemporary example date for release tags and recommends using git pull --rebase for the release-decaf branch to avoid unnecessary merge commits before force-pushing.
Comment on lines
+60
to
+61
| git tag 19700101 | ||
| git push origin 19700101 |
There was a problem hiding this comment.
The example tag 19700101 corresponds to the start of the Unix epoch. While technically valid, it might be confusing as a general example for the YYYYMMDD[-optional-description] format. Using a more generic date could improve clarity.
Suggested change
| git tag 19700101 | |
| git push origin 19700101 | |
| git tag 20240101 | |
| git push origin 20240101 |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.