Bump kona-celo-fork to PR 19 head (EspressoEnforcementTime hardfork)#14
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request pins multiple dependencies to specific git revisions in Cargo.lock and Cargo.toml, replacing branch-based references for the celo-kona and kona-celo-fork repositories. Feedback suggests documenting the shared revision hash in the group comments within Cargo.toml to improve maintainability and simplify future updates.
| celo-driver = { git = "https://github.com/EspressoSystems/celo-kona", rev = "b6fdd1239e3871dca00b4058d4f92387cfbb9fe7" } | ||
| celo-proof = { git = "https://github.com/EspressoSystems/celo-kona", rev = "b6fdd1239e3871dca00b4058d4f92387cfbb9fe7" } | ||
| celo-host = { git = "https://github.com/EspressoSystems/celo-kona", rev = "b6fdd1239e3871dca00b4058d4f92387cfbb9fe7" } | ||
| celo-protocol = { git = "https://github.com/EspressoSystems/celo-kona", rev = "b6fdd1239e3871dca00b4058d4f92387cfbb9fe7", default-features = false } | ||
| celo-genesis = { git = "https://github.com/EspressoSystems/celo-kona", rev = "b6fdd1239e3871dca00b4058d4f92387cfbb9fe7", default-features = false } | ||
| celo-registry = { git = "https://github.com/EspressoSystems/celo-kona", rev = "b6fdd1239e3871dca00b4058d4f92387cfbb9fe7", default-features = false } |
There was a problem hiding this comment.
While pinning dependencies to a specific revision is a great improvement for reproducibility, the revision b6fdd123... is repeated for multiple celo-kona dependencies. This could be a maintenance concern for future updates.
To make this easier to manage, consider adding the revision to the group comment. This makes it clear that all dependencies in the group share the same revision and simplifies future updates via search-and-replace.
For example:
- # celo-kona
+ # celo-kona @ b6fdd1239e3871dca00b4058d4f92387cfbb9fe7This same pattern could be applied to other dependency groups in this file that share a common source and revision, like the [patch."https://github.com/op-rs/kona"] section.
QuentinI
force-pushed
the
bump/kona-celo-fork-pr19
branch
2 times, most recently
from
d267c7d to
38611a0
Compare
Update to: - celo-kona @ 8dc2e3e4 (espresso-integration-rebase-1) - kona-celo-fork @ f95b1a62 (espresso-integration-rebase-1, EspressoEnforcementTime hardfork celo-org#19) Patch upstream kona-cli to the fork as well, so that transitive deps (celo-host, hana-host, hokulea-host-bin) build against our fork's kona-cli which initializes the new HardForkConfig.espresso_enforcement_time field. Co-authored-by: OpenCode <noreply@opencode.ai>
QuentinI
force-pushed
the
bump/kona-celo-fork-pr19
branch
from
38611a0 to
c509acf
Compare
1 participant
No description provided.