feat: Upgrade to v3.9.9#12
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the .github/CODEOWNERS file to replace specific directory owners with a set of default owners for the entire repository. It also introduces a new file, core/rawdb/espresso_freezer.go, containing the NewEspressoTableConfig function. Feedback on the new implementation suggests optimizing map initialization by providing a capacity hint and correcting a minor formatting issue regarding the assignment operator.
| package rawdb | ||
|
|
||
| func NewEspressoTableConfig(tables map[string]bool) map[string]freezerTableConfig { | ||
| result:= make(map[string]freezerTableConfig) |
There was a problem hiding this comment.
The map initialization is missing a space before the := operator, which violates standard Go formatting. Additionally, since the size of the tables map is known, it is more efficient to provide a capacity hint to make to avoid unnecessary reallocations as the map grows.
| result:= make(map[string]freezerTableConfig) | |
| result := make(map[string]freezerTableConfig, len(tables)) |
References
- Standard Go formatting (gofmt) requires a space before and after the := operator. (link)
Puts
espresso go-ethereumon top ofv3.9.9 go-ethereum