Skip to content

feat: Upgrade to v3.9.9#12

Open
varun-doshi wants to merge 1 commit into
integration-v3.9.9from
vd/upgrade-v3.9.9-release
Open

feat: Upgrade to v3.9.9#12
varun-doshi wants to merge 1 commit into
integration-v3.9.9from
vd/upgrade-v3.9.9-release

Conversation

@varun-doshi
Copy link
Copy Markdown

Puts espresso go-ethereum on top of v3.9.9 go-ethereum

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/CODEOWNERS file to replace specific directory owners with a set of default owners for the entire repository. It also introduces a new file, core/rawdb/espresso_freezer.go, containing the NewEspressoTableConfig function. Feedback on the new implementation suggests optimizing map initialization by providing a capacity hint and correcting a minor formatting issue regarding the assignment operator.

package rawdb

func NewEspressoTableConfig(tables map[string]bool) map[string]freezerTableConfig {
result:= make(map[string]freezerTableConfig)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The map initialization is missing a space before the := operator, which violates standard Go formatting. Additionally, since the size of the tables map is known, it is more efficient to provide a capacity hint to make to avoid unnecessary reallocations as the map grows.

Suggested change
result:= make(map[string]freezerTableConfig)
result := make(map[string]freezerTableConfig, len(tables))
References
  1. Standard Go formatting (gofmt) requires a space before and after the := operator. (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant