Skip to content

Upgrade to v3.9.8 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
varun-doshi merged 1 commit into from
Apr 3, 2026
Merged

Upgrade to v3.9.8 #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 4 additions & 32 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,5 @@
# Lines starting with '#' are comments.
# Each line is a file pattern followed by one or more owners.
# These owners will be the default owners for everything in the repo. Unless a
# later match takes precedence, they will be requested for review when someone
# opens a pull request.

accounts/usbwallet/ @gballet
accounts/scwallet/ @gballet
accounts/abi/ @gballet @MariusVanDerWijden
beacon/engine/ @MariusVanDerWijden @lightclient @fjl
beacon/light/ @zsfelfoldi
beacon/merkle/ @zsfelfoldi
beacon/types/ @zsfelfoldi @fjl
beacon/params/ @zsfelfoldi @fjl
cmd/evm/ @MariusVanDerWijden @lightclient
core/state/ @rjl493456442
crypto/ @gballet @jwasinger @fjl
core/ @rjl493456442
eth/ @rjl493456442
eth/catalyst/ @MariusVanDerWijden @lightclient @fjl @jwasinger
eth/tracers/ @s1na
ethclient/ @fjl
ethdb/ @rjl493456442
event/ @fjl
trie/ @rjl493456442 @gballet
triedb/ @rjl493456442
core/tracing/ @s1na
graphql/ @s1na
internal/ethapi/ @fjl @s1na @lightclient
internal/era/ @lightclient
miner/ @MariusVanDerWijden @fjl @rjl493456442
node/ @fjl
p2p/ @fjl @zsfelfoldi
rlp/ @fjl
params/ @fjl @gballet @rjl493456442 @zsfelfoldi
rpc/ @fjl
* @ImJeremyHe @zacshowa @Sneh1999 @philippecamacho @jjeangal
9 changes: 9 additions & 0 deletions core/rawdb/espresso_freezer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package rawdb

func NewEspressoTableConfig(tables map[string]bool) map[string]freezerTableConfig {
Copy link
Copy Markdown

@zacshowa zacshowa Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because I lack context; whats up with this?
I only ask because we encountered some weird error related to parsing some freezer table type on startup while deploying NodeOps yesterday.

Copy link
Copy Markdown
Author

@varun-doshi varun-doshi Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no custom change made in this PR
This is basically the same as this PR: #9

But for context on the code maybe @Sneh1999 can provide more info

result:= make(map[string]freezerTableConfig)
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The map result is initialized without a specified capacity. Since the number of elements is known from the tables input, it is more efficient to pre-allocate the map capacity using len(tables) to avoid multiple re-allocations during the loop. Additionally, there is a minor style issue: there should be a space before the := operator to adhere to standard Go formatting (gofmt).

Suggested change
result:= make(map[string]freezerTableConfig)
result := make(map[string]freezerTableConfig, len(tables))
References
  1. Standard Go formatting (gofmt) requires a space before the := operator for readability. (link)

for key, value := range tables {
result[key] = freezerTableConfig{noSnappy: value, prunable: true}
}
return result
}
Loading