Add nitro support by lukeiannucci · Pull Request #39 · EspressoSystems/espresso-rollup-node-proxy

lukeiannucci · 2026-04-29T20:53:41Z

Closes #<ISSUE_NUMBER>

This PR:

Add initial support for the nitro verifier. Also a docker compose setup that spins up a sequencer, batchposter, and fullnode. To test this out you can do:

cd espresso_e2e/nitro && docker compose up -d && cd ../..

Then run the verifier:

go run . --nitro.enable --nitro.namespace 412346 --nitro.query-service-url http://localhost:24000 --nitro.valid-batcher-addresses 0x3f1Eae7D46d88F08fc2F8ed27FCb2AB183EB2d0E --nitro.initial-hotshot-block 0 --nitro.feed-url ws://localhost:9643 --full-node-execution-rpc http://localhost:8549 --listen-addr :8080 --nitro.verification-interval 100ms

This PR does not:

Add any e2e tests to reduce the size of the PR.

Key places to review:

gemini-code-assist

Code Review

This pull request introduces a Nitro batch verifier and an end-to-end testing environment for Nitro-Espresso integration. Key additions include a Docker Compose setup, Nitro configuration files, and a NitroEspressoBatchVerifier that ensures Nitro full node blocks align with data from the Espresso streamer. Feedback focuses on improving the mockLightClient implementation to handle errors and context correctly, correcting a hostname in the Nitro configuration, optimizing block verification by using headers instead of full blocks, and adding validation for the verification interval to prevent potential panics.

Sneh1999 · 2026-05-12T13:24:24Z

+            "wait-for-max-delay": false,
+            "l1-block-bound": "ignore",
+            "parent-chain-wallet": {
+                "private-key": "b6b15c8cb491557369f3c7d2c287b053eb229daa9c22138887752191c9520659"


why did we push private key here?

https://docs.arbitrum.io/run-arbitrum-node/run-nitro-dev-node#development-account-used-by-default

this is the address it uses. i will move it to the env file and pass it in as parameter though

Sneh1999 · 2026-05-12T13:25:14Z

@@ -0,0 +1,157 @@
+services:
+  l1-geth:
+    image: ghcr.io/espressosystems/timeboost/geth-l1:rollup-creator-round2


why are we using timeboost image?

this was a prebuilt l1 image we used for timeboost. i will move away from this.

Sneh1999 · 2026-05-12T13:25:45Z

+      ESPRESSO_SEQUENCER_L1_PROVIDER: http://l1-geth:${L1_HTTP_PORT}
+      ESPRESSO_DEPLOYER_ACCOUNT_INDEX: 0
+      ESPRESSO_DEV_NODE_EPOCH_HEIGHT: "4294967295"
+      ESPRESSO_SEQUENCER_ETH_MNEMONIC: "giant issue aisle success illegal bike spike question tent bar rely arctic volcano long crawl hungry vocal artwork sniff fantasy very lucky have athlete"


this should go in .env

Sneh1999 · 2026-05-12T13:26:37Z

@@ -0,0 +1,161 @@
+package feedclient


have you copy pasted this file from Nitro?

no i looked at the nitro code and tried to make it simpler, all we need to do is stream in the messages from the feed. I can look to make this cleaner and make sure i didnt miss anything

Sneh1999 · 2026-05-12T13:27:25Z

+	espressoStore "proxy/store"
+
+	espressoClient "github.com/EspressoSystems/espresso-network/sdks/go/client"
+	nitroStreamer "github.com/EspressoSystems/espresso-streamers/nitro"


should we first do a pr to espresso streamers repo?

Sneh1999 · 2026-05-12T13:43:06Z

+	}
+	if !updated {
+		v.logger.Warn("espresso state not updated — message position not greater than current",
+			"msg_pos", espressoMsg.Pos)


we can add a return here, but i also need to advance the streamer.

Sneh1999 · 2026-05-12T13:43:42Z

+	return header.Number.Uint64(), nil
+}
+
+func (v *NitroEspressoBatchVerifier) syncEspressoStateWithNitroFinality(nitroFinalizedBlock uint64) error {


I think this function can be common between the two verifiers

Sneh1999 · 2026-05-12T13:44:23Z

+	// lives in the L1 delayed inbox and is not included in the messages sent to hotshot.
+	// In that case only compare the header and delayed message counter.
+	if len(espresso.Message.L2msg) == 0 {
+		espressoHeader, feedHeader := espresso.Message.Header, feed.Message.Header


I dont think you need to compare exact values, just convert to bytes using rlp that nitro uses and then compare the bytes or else you will have to change the code if they change any field or anything

this is only for delayed messages as the feed will have l2 msg data, and what comes from espresso does not. maybe its enough to just check the delayed messages read?

Sneh1999 · 2026-05-12T13:44:54Z

+		espressoHeader := espresso.Message.Header
+		feedHeader := feed.Message.Header
+		return fmt.Errorf(
+			"espresso message does not match Nitro feed message\n"+


This error is pretty ugly

yea i was actually debugging something with an issue and was printing out too much stuff. im going to make this a lot simpler now

Sneh1999 · 2026-05-12T13:46:56Z

+	v.logger.Info("Nitro verifier stopped")
+}
+
+func ValidateNitroVerifierConfig(config *NitroEspressoBatchVerifierConfig) error {


can you put this in config file?

i dont believe this is needed, when i first started i wrote my own parser but since moved the logic inside validate(). Good catch going to delete.

Sneh1999

Can you add tests it seems like most files are missing tests?

start for nitro

04ffce4

gemini-code-assist Bot reviewed Apr 29, 2026

View reviewed changes

Comment thread mock_light_client.go Outdated

Comment thread espresso_e2e/nitro/nitro-config/nitro_config.json Outdated

Comment thread verifier/nitro/nitro_verifier.go Outdated

Comment thread verifier/nitro/nitro_verifier.go

lukeiannucci added 6 commits April 29, 2026 18:06

fixes

0528932

changes

dd5a7c2

Merge branch 'main' into li/start-nitro

ba1fd18

WIP

8a56503

cleanup

20aef14

cleanup

24822bb

lukeiannucci changed the title ~~start for nitro~~ Add nitro support May 11, 2026

lint

9b986e9

lukeiannucci marked this pull request as ready for review May 11, 2026 21:53

lukeiannucci requested review from Ayiga, ImJeremyHe, QuentinI, Sneh1999, jbearer, jjeangal, philippecamacho, shenkeyao and varun-doshi as code owners May 11, 2026 21:53

remove uneeded

cd7379d

lukeiannucci changed the base branch from main to feat-nitro May 11, 2026 22:01

fix startup

7327808

Sneh1999 reviewed May 12, 2026

View reviewed changes

Conversation

lukeiannucci commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR:

This PR does not:

Key places to review:

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukeiannucci May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukeiannucci May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sneh1999 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lukeiannucci commented Apr 29, 2026 •

edited

Loading

lukeiannucci May 12, 2026 •

edited

Loading

lukeiannucci May 12, 2026 •

edited

Loading