Deployer tech debt#3813
Merged
alysiahuggins merged 12 commits intomainfrom Dec 11, 2025
Merged
Conversation
… because transfer_ownership_from_eoa needs it for the EOA to timelock transition, once hte timelock owns it, it is managed via timelock operations
alysiahuggins
requested review from
bfish713,
imabdulbasit,
jbearer,
lukaszrzasik,
pls148,
rob-maron,
ss-es and
sveitser
as code owners
sveitser
reviewed
Dec 9, 2025
| let tx_hash = *pending_tx.tx_hash(); | ||
| tracing::info!(%tx_hash, "waiting for tx to be mined"); | ||
| let receipt = pending_tx.get_receipt().await?; | ||
| if !receipt.inner.is_success() { |
Collaborator
There was a problem hiding this comment.
There is receipt.status()
sveitser
reviewed
Dec 9, 2025
|
|
||
| /// Option to deploy StakeTable V1 | ||
| #[clap(long, default_value = "false")] | ||
| deploy_stake_table_v1: bool, |
Collaborator
There was a problem hiding this comment.
I think these API changes to the deploy binary will break most deploy scripts that are used for testing and production. Is there enough benefit to justify that?
Collaborator
There was a problem hiding this comment.
edit: i see there some work for backwards compat. Log a warning to inform the user that they are using a deprecated argument if they do?
sveitser
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
--timelock-addressflag, users no longer need to specify timelock addresses manually, it is derived from the already deployed timelock as timelock selection is automaticThis PR does not:
Key places to review: