Conversation
alysiahuggins
commented
Nov 26, 2025
alysiahuggins
requested review from
bfish713,
imabdulbasit,
jbearer,
lukaszrzasik,
pls148,
rob-maron,
ss-es and
sveitser
as code owners
sveitser
approved these changes
Nov 26, 2025
sveitser
reviewed
Dec 1, 2025
Collaborator
|
@alysiahuggins I thought the conclusion is that we will only read from the LC in the initializer, validate there that min < max and set those limits there? |
sveitser
approved these changes
Dec 3, 2025
alysiahuggins
changed the title
alysiahuggins
commented
Dec 4, 2025
sveitser
reviewed
Dec 4, 2025
sveitser
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
The lower bound is dynamically set over a function call to lightClient.blocksPerEpoch() . If lightClient.blocksPerEpoch() returns a value where blocksPerEpoch() * 15 > 86400 * 14; // 14 days , the minimum would exceed the maximum, causing all calls to updateExitEscrowPeriod() to revert with ExitEscrowPeriodInvalid()
This PR:
makes the maximum dynamic based on light client parameters.
This PR does not:
Key places to review: