Skip to content

Remove deliberate null assignment#359

Merged
Ayiga merged 1 commit into
mainfrom
ts/fix/remove-deliberate-null-in-histogram-data
May 8, 2026
Merged

Remove deliberate null assignment#359
Ayiga merged 1 commit into
mainfrom
ts/fix/remove-deliberate-null-in-histogram-data

Conversation

@Ayiga
Copy link
Copy Markdown
Member

@Ayiga Ayiga commented May 8, 2026

This PR:

Removes a line added to deliberately trigger a condition in the local demo (in order to demonstrate the missing data correction).

While implementing missing data in the histogram by backfill existing
data (should it exist), a deliberate modification to intentionally
trigger the condition in the local environment was accidentally
committed.

This removes the intentional `null` to fix data integrity.
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a hardcoded line in the explorerOverviewStream function that was setting the 10th index of the block size histogram to null. I have no feedback to provide as there were no review comments to evaluate.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Coverage Report for Espresso Block Explorer Components (./packages/espresso-block-explorer-components/)

Status Category Percentage Covered / Total
🔵 Lines 72.51% 9730 / 13418
🔵 Statements 72.54% 9834 / 13556
🔵 Functions 65.76% 2536 / 3856
🔵 Branches 55.54% 2488 / 4479
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/espresso-block-explorer-components/src/sites/block_explorer/pages/hot_shot_query_service_adapters.tsx 45.28% 0% 56.25% 45.28% 101-217, 248-284, 310
Generated in workflow #949 for commit 34614d9 by the Vitest Coverage Report Action

@Ayiga Ayiga merged commit 889f051 into main May 8, 2026
7 checks passed
@Ayiga Ayiga deleted the ts/fix/remove-deliberate-null-in-histogram-data branch May 8, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant