Fix return_to being ignored after OAuth login#4916
Open
barnabasdomozi wants to merge 1 commit into
Open
Conversation
Persist the return_to query parameter in localStorage before redirecting to the OAuth provider, since the browser navigation loses query params. After successful OAuth callback, read it back and navigate accordingly instead of always redirecting to the app root. Also set userName to null on OAuth login so the actual username is fetched from the server via getLoggedInUser instead of using a placeholder string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist the return_to query parameter in localStorage before redirecting to the OAuth provider, since the browser navigation loses query params. After successful OAuth callback, read it back and navigate accordingly instead of always redirecting to the app root.
Also set userName to null on OAuth login so the actual username is fetched from the server via getLoggedInUser instead of using a placeholder string.