Skip to content

Refactor/replace report filter button icon#4907

Open
feyruzb wants to merge 3 commits into
Ericsson:masterfrom
feyruzb:refactor/replace-report-filter-button-icon
Open

Refactor/replace report filter button icon#4907
feyruzb wants to merge 3 commits into
Ericsson:masterfrom
feyruzb:refactor/replace-report-filter-button-icon

Conversation

@feyruzb

@feyruzb feyruzb commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

This pull request updates the PresetMenu component in the report filter UI to improve the user experience and clarify icon usage. The main changes focus on the appearance and behavior of the preset selection and deletion controls.

UI/UX improvements:

  • The clear icon for the v-select component is now set to mdi-delete for better clarity when clearing a preset.
  • The menu dropdown uses a scrim and closes on scroll for improved usability, and the order of some props is adjusted for clarity.

Icon and button updates:

  • The delete/cancel icon in the preset list is now larger (size="large") and uses mdi-close-circle instead of mdi-delete for clearer intent.

Closes #4906

@feyruzb feyruzb requested a review from bruntib June 19, 2026 15:31
@feyruzb feyruzb self-assigned this Jun 19, 2026
@feyruzb feyruzb added usability 👍 Usability-related features refactoring 😡 ➡️ 🙂 Refactoring code. style 📝 Formatting, missing semi colons, etc; no code change labels Jun 19, 2026

@gulyasgergely902 gulyasgergely902 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not exactly what the ticket asked for but it might not be clear what it wanted. The goal of the ticket was to replace all buttons which deletes anything to a trashcan icon and use the cross icon to unselect a selection. For example the filter preset selection has it inverted now: the delete action (deleting a preset) has the cross icon and the unselection action has a trashcan. Please replace the icons which only unselects (for the whole filter sidebar) to a cross and add the trashcan to buttons which irreversibly deletes the given entity (currently only applicable for filter presets).

@dkrupp dkrupp added this to the release 6.28.2 milestone Jun 23, 2026
@feyruzb feyruzb requested a review from gulyasgergely902 June 24, 2026 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI 🎨 refactoring 😡 ➡️ 🙂 Refactoring code. style 📝 Formatting, missing semi colons, etc; no code change usability 👍 Usability-related features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace reset report filter button icon

3 participants