Refactor/replace report filter button icon#4907
Open
feyruzb wants to merge 3 commits into
Open
Conversation
gulyasgergely902
requested changes
Jun 22, 2026
gulyasgergely902
left a comment
Collaborator
There was a problem hiding this comment.
This is not exactly what the ticket asked for but it might not be clear what it wanted. The goal of the ticket was to replace all buttons which deletes anything to a trashcan icon and use the cross icon to unselect a selection. For example the filter preset selection has it inverted now: the delete action (deleting a preset) has the cross icon and the unselection action has a trashcan. Please replace the icons which only unselects (for the whole filter sidebar) to a cross and add the trashcan to buttons which irreversibly deletes the given entity (currently only applicable for filter presets).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
PresetMenucomponent in the report filter UI to improve the user experience and clarify icon usage. The main changes focus on the appearance and behavior of the preset selection and deletion controls.UI/UX improvements:
v-selectcomponent is now set tomdi-deletefor better clarity when clearing a preset.Icon and button updates:
size="large") and usesmdi-close-circleinstead ofmdi-deletefor clearer intent.Closes #4906