Repository navigation
⬆️ Bump dependencies - #15
Conversation
| github.com/moby/buildkit v0.13.2 | ||
| github.com/containerd/containerd v1.7.31 | ||
| github.com/distribution/reference v0.6.0 | ||
| github.com/moby/buildkit v0.29.0 |
There was a problem hiding this comment.
This is the bump I'm most interested in. Some changes in HEALTHCHECK
| return res, err | ||
| } | ||
|
|
||
| func (proxy *dockerfileTransformingLLBProxy) ReadFileContainer(ctx context.Context, in *pb.ReadFileRequest, opts ...grpc.CallOption) (*pb.ReadFileResponse, error) { |
There was a problem hiding this comment.
New methods added to the interface in moby/buildkit#6262
There was a problem hiding this comment.
As far as I can tell, this is used to inspect filesystems of running containers (potentially to support debugging via moby/buildkit#5938). I don't think we need to include the transform logic here for now. What do you think?
There was a problem hiding this comment.
Yes seems so . I added it here b/c it was added to the interface returned by NewDockerfileTransformingLLBProxy, and admittedly I'm not sure how that interface ends up being used in here - someplace inside the client.Client I think.
Easy to define its own interface here instead - I tried it and it at least builds & tests pass.
There was a problem hiding this comment.
I don't have a strong preference. Let's stick with what you got here.
|
@EricHripko for your review |
There was a problem hiding this comment.
Pull request overview
Updates Go module dependencies (notably BuildKit) and adapts the codebase to upstream API changes introduced by the newer SDK.
Changes:
- Bumped Go module dependencies via
go get -u ./...andgo mod tidy(major BuildKit upgrade). - Updated BuildKit gateway proxy and generated mocks to support new
*ContainerRPCs. - Adjusted image config resolution options (
sourceresolver.Opt) to match updated BuildKit API.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/dtp/proxy.go | Adds forwarding methods for new ReadFileContainer/ReadDirContainer/StatFileContainer calls (including Dockerfile transform on container reads). |
| pkg/dtp/mock/client.go | Regenerates GoMock client to include new *Container methods. |
| pkg/cib/service.go | Updates ResolveImageConfig option wiring to new ResolveImageOpt structure. |
| pkg/cib/service_test.go | Updates tests to match the new sourceresolver.Opt structure. |
| go.mod | Updates direct/indirect dependencies and changes the module go version line. |
| go.sum | Updates checksums for the new dependency graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
CI seems to be failing still - let me know if you need a hand with fixing this up 👍 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
===========================================
- Coverage 89.16% 28.02% -61.15%
===========================================
Files 5 9 +4
Lines 277 885 +608
===========================================
+ Hits 247 248 +1
- Misses 26 633 +607
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I think we need to upgrade https://github.com/golangci/golangci-lint-action to a newer version to utilise the newer |
|
Thanks for the pointer @EricHripko. Updated golangci-lint |
|
Sorry for the delay in getting back to you! Final stretch - looks like there's a few lints that |
|
Updated - I think I've got it, mostly packages moving around. |
EricHripko
left a comment
EricHripko
left a comment
There was a problem hiding this comment.
Looks great ✅ Thank you for taking the time to contribute 🙌
Ran
go get -u ./...andgo mod tidy.Then a few fixes noted for changes in buildkit sdk.