fix(results): name and link Bloc STAR on the results page - #1475
Draft
masiarek wants to merge 2 commits into
Draft
fix(results): name and link Bloc STAR on the results page#1475masiarek wants to merge 2 commits into
masiarek wants to merge 2 commits into
Conversation
A STAR race with more than one seat is Bloc STAR, but the method is stored as plain "STAR" with the seat count in a separate field, so the results page labelled it "STAR Voting" and pointed "How STAR Voting works" at the single-winner explainer. Derive the bloc case where the page names the method. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
A STAR race with more than one seat is Bloc STAR, but the method is stored as plain "STAR" with the seat count in a separate field, so the results page labelled it "STAR Voting" and pointed "How STAR Voting works" at the single-winner explainer. Derive the bloc case where the page names the method. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
✅ Deploy Preview for bettervoting ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The results-page half of #1086. A STAR race with more than one seat is Bloc STAR, but the method is stored as plain
"STAR"with the seat count in a separate field (num_winners), soResults.tsxhad no way to know and:methods.star.learn_link, the single-winner explainer.Both come from the same two lines, so both are fixed by deriving the bloc case once:
plus a
methods.star_blocblock (full_name: Bloc STAR Voting,short_name: Bloc STAR,learn_link) alongside the existingstar/star_prentries.Scope — deliberately narrow, three things left alone:
votingMethod: "STAR"+num_winnersis arguably correct — the field names the ballot/tabulation family and the seat count names the seats, making "Bloc STAR" a derived label. This PR treats it that way and derives it at the display layer only. (Reasoning and the exact export lines: BV129 note.)edit_race.bloc_multi_winner_adj), and doing it properly means deciding how the adjective composes for every method — Bloc Approval, Bloc Ranked Robin, multi-winner Plurality — which is a naming decision for maintainers, not a drive-by. Same reason Method name is incorrect - BV18 - Basic - Plurality - 5 candidates - 2 seats #912 and BV1820 - method names - STAR - STAR Bloc - STAR PR #904 exist.useSubstitutedTranslation'smethodKey(line ~450) is untouched — it feeds term substitution across many strings, and widening it is a separate blast radius.So #1086 shouldn't be auto-closed by this; it should lose one of its three problem areas.
Translations: en-only.
es/pl/pt-BReach carry amethods:block, so a missingstar_blocfalls back to English rather than rendering a key — same behaviour as any newly added string.Alternative if you don't want #1474: point
methods.star_bloc.learn_linkathttps://electowiki.org/wiki/Bloc_STAR_Voting, as #1086 originally suggested, and this becomes independent and mergeable today.Screenshots / Videos (frontend only)
Text-only change to an existing label and an existing anchor — no layout, no new elements. On a 2-seat STAR race the label reads "Voting Method: Bloc STAR Voting" and the link reads "How Bloc STAR Voting works".
Related Issues
Part of #1086 (results-page half only — see scope above). Follows #1474.
🤖 Generated with Claude Code