Skip to content

feat: prefer secure connections in server discovery fallback #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongfengweixiao wants to merge 1 commit into from
Closed

feat: prefer secure connections in server discovery fallback #281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions lib/src/private/util/discover_helper.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,15 +157,25 @@ class DiscoverHelper {
futures.add(_tryToConnect(info, isLogEnabled));
}
final results = await Future.wait(futures);
// Prefer secure connections, then fall back to non-secure
final imapInfo = results.firstWhereOrNull(
(info) => info.ready(ServerType.imap),
);
(info) => info.ready(ServerType.imap) && info.isSecure,
) ??
results.firstWhereOrNull(
(info) => info.ready(ServerType.imap),
);
final popInfo = results.firstWhereOrNull(
(info) => info.ready(ServerType.pop),
);
(info) => info.ready(ServerType.pop) && info.isSecure,
) ??
results.firstWhereOrNull(
(info) => info.ready(ServerType.pop),
);
final smtpInfo = results.firstWhereOrNull(
(info) => info.ready(ServerType.smtp),
);
(info) => info.ready(ServerType.smtp) && info.isSecure,
) ??
results.firstWhereOrNull(
(info) => info.ready(ServerType.smtp),
);
if ((imapInfo == null && popInfo == null) || (smtpInfo == null)) {
print(
'failed to find settings for $baseDomain: '
Expand Down