🐛 Blueprint読込時にload_projectを通知する - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
.ajblueprintを開いた際に欠けていたBlockbench標準のload_project通知を追加します。プロジェクト名と保存先を確定してから通知し、その後にBlueprintをparseします。主な変更
load_projectをmodelとpath付きで1回通知Project.nameとProject.save_pathを通知前に設定動作確認
yarn test: 104 tests passed、1 todoyarn prettier src/formats/blueprint/codec.ts --check: 成功yarn eslint src/formats/blueprint/codec.ts: 成功yarn prod: warnings 0、errors 0git diff --check: 成功