pyln-testing: give btcproxy a port and choose better ports - #9399
Draft
daywalker90 wants to merge 1 commit into
Draft
pyln-testing: give btcproxy a port and choose better ports#9399daywalker90 wants to merge 1 commit into
daywalker90 wants to merge 1 commit into
Conversation
daywalker90
force-pushed
the
pyln-testing-port-magic
branch
from
August 10, 2026 18:45
f5d703c to
386880d
Compare
Collaborator
Author
|
8/8 successfull |
daywalker90
force-pushed
the
pyln-testing-port-magic
branch
6 times, most recently
from
August 11, 2026 14:40
66ca50d to
21a5ca0
Compare
btcproxy was using port 0 by default without going through our port reservation logic, so it may have caused "Address already in use" issues. It was also binding to 0.0.0.0, so on all addresses. For the port reservations to work we use 127.0.0.1 here too. We choose from outside the source-port range of ports in hopes of avoiding more port bind race conditions. Changelog-None
daywalker90
force-pushed
the
pyln-testing-port-magic
branch
from
August 11, 2026 16:20
21a5ca0 to
5314b03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
btcproxy was using port 0 by default without going through our port reservation logic, so it may have caused "Address already in use" issues. It was also binding to 0.0.0.0, so on all addresses. For the port reservations to work we use 127.0.0.1 here too.
We choose from outside the source-port range of ports in hopes of avoiding more port bind race conditions.
Fixes: #9381
(hopefully)
I'm going to do like 10 CI runs to see if it improves.