Skip to content

fix(web): keep the aspect ratio of the LCD, move the build info to the bottom - #7967

Merged
raphaelcoeffic merged 3 commits into
mainfrom
fix-web-lcd-aspect-ratio
Nov 1, 2026
Merged

raphaelcoeffic merged 3 commits into
mainfrom
fix-web-lcd-aspect-ratio

Conversation

@raphaelcoeffic

@raphaelcoeffic raphaelcoeffic commented Nov 1, 2026 •

Copy link
Copy Markdown
Member

Summary of changes:

Based on #7964, as the build info moved here is added there. Merge that first, then this one targets main.

The LCD canvas had a fixed height, while its width was limited to the space available. Any LCD wider than that space got stretched vertically: the TX16S MK3 was 631x480 on every desktop window size, and all radios were affected on a phone.

  • Aspect ratio: the height now follows from the width.
  • TX16S MK3 size: it is shown 582x349 rather than 800x480. Its LCD is only a little larger than a 480x272 one, with a higher density. The scale of 1.375 is the firmware's LAYOUT_SCALE for this LCD, which makes the UI the same size on the page as on other radios. Smooth scaling replaces pixelated here, as the scale isn't a whole number. Every other radio keeps its current width on desktop.
  • Build info: the commit and date move from the header to a footer below the trace output, where they draw less attention.

Testing

Tested on top of #7964, as 25 radios, including the MK3, cannot start on main without it.

  • The LCD ratio of all 47 radios at 1920, 1280, 1000 and 390 pixels wide: 50 wrong before, none after.
  • The smoke test from ci(web): publish the web simulator to Cloudflare Workers #7964 passes on all 47 radios, with all of these changes.
  • The footer shows below the radio at 1280 and 390 pixels wide, and no longer in the header.

Not changed: the page is still wider than a phone screen, and the LCD is small there. Touch input was not exercised, though it already scales positions by the displayed size of the canvas.

@raphaelcoeffic raphaelcoeffic changed the title fix(web): keep the aspect ratio of the LCD fix(web): keep the aspect ratio of the LCD, move the build info to the bottom Nov 1, 2026
@raphaelcoeffic
raphaelcoeffic changed the base branch from main to ci-web-simulator-workers November 1, 2026 12:06
Base automatically changed from ci-web-simulator-workers to main November 1, 2026 12:18
The width of the canvas is limited to what is available, but its height was
fixed, which stretched the 800x480 LCD of the TX16S MK3 vertically on any
screen, and every LCD on a phone.

The height now follows from the width. The MK3 is also shown at 550px rather
than 800px wide, as its LCD is only a little larger than a 480x272 one, and has
a higher density.
LAYOUT_SCALE is 1.375 on an 800 pixels wide LCD. Using it rather than an estimate
from the panel sizes makes the UI the same size on the page as on other radios.
It drew attention in the header, for something only useful when looking for the
deployed version.
@raphaelcoeffic
raphaelcoeffic force-pushed the fix-web-lcd-aspect-ratio branch from c456341 to 8ff80c6 Compare November 1, 2026 12:18
@raphaelcoeffic
raphaelcoeffic merged commit bea2736 into main Nov 1, 2026
6 checks passed
@raphaelcoeffic
raphaelcoeffic deleted the fix-web-lcd-aspect-ratio branch November 1, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant