Repository navigation
fix(web): keep the aspect ratio of the LCD, move the build info to the bottom - #7967
Merged
Merged
Conversation
The width of the canvas is limited to what is available, but its height was fixed, which stretched the 800x480 LCD of the TX16S MK3 vertically on any screen, and every LCD on a phone. The height now follows from the width. The MK3 is also shown at 550px rather than 800px wide, as its LCD is only a little larger than a 480x272 one, and has a higher density.
LAYOUT_SCALE is 1.375 on an 800 pixels wide LCD. Using it rather than an estimate from the panel sizes makes the UI the same size on the page as on other radios.
It drew attention in the header, for something only useful when looking for the deployed version.
raphaelcoeffic
force-pushed
the
fix-web-lcd-aspect-ratio
branch
from
November 1, 2026 12:18
c456341 to
8ff80c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
Based on #7964, as the build info moved here is added there. Merge that first, then this one targets
main.The LCD canvas had a fixed height, while its width was limited to the space available. Any LCD wider than that space got stretched vertically: the TX16S MK3 was 631x480 on every desktop window size, and all radios were affected on a phone.
LAYOUT_SCALEfor this LCD, which makes the UI the same size on the page as on other radios. Smooth scaling replacespixelatedhere, as the scale isn't a whole number. Every other radio keeps its current width on desktop.Testing
Tested on top of #7964, as 25 radios, including the MK3, cannot start on
mainwithout it.Not changed: the page is still wider than a phone screen, and the LCD is small there. Touch input was not exercised, though it already scales positions by the displayed size of the canvas.