Skip to content

fix(build): hardware_defs target fails since hal.h includes generated headers #7880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfeerick merged 1 commit into from
Oct 7, 2026
Merged

fix(build): hardware_defs target fails since hal.h includes generated headers #7880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion cmake/Macros.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@ function(AddHardwareDefTarget output)

set(HW_DEF_SRC ${RADIO_DIRECTORY}/src/targets/${TARGET_DIR}/hal.h)

# hal.h includes headers generated into the binary dir (hal_settings.h,
# hal_pwm_sticks.h), which is not yet an include directory at this point
set(HW_DEF_GENERATED
${CMAKE_CURRENT_BINARY_DIR}/hal_settings.h
${CMAKE_CURRENT_BINARY_DIR}/hal_pwm_sticks.h)
set(HW_DEF_ARGS ${HW_DEF_ARGS} -I${CMAKE_CURRENT_BINARY_DIR})

separate_arguments(flags UNIX_COMMAND ${CMAKE_CXX_FLAGS})
foreach(flag ${flags})
set(HW_DEF_ARGS ${HW_DEF_ARGS} ${flag})
Expand All @@ -108,7 +115,7 @@ function(AddHardwareDefTarget output)

add_custom_command(OUTPUT ${output}.h
COMMAND ${GEN_HW_DEFS} > ${output}.h
DEPENDS ${HW_DEF_SRC} ${RADIO_DIRECTORY}/util/hw_defs/generate_hw_def.py
DEPENDS ${HW_DEF_SRC} ${HW_DEF_GENERATED} ${RADIO_DIRECTORY}/util/hw_defs/generate_hw_def.py
)
endfunction()

Expand Down
Loading