Repository navigation
fix(t15): default SF to TOGGLE on T15 and T15 Pro - #7870
Merged
Merged
Conversation
SF is a momentary switch on both radios, so it should default to TOGGLE, not 2POS. Existing radio.yml files keep their stored switch type; only new or reset radio settings pick up the new default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
added
bug 🪲
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SF on the Jumper T15 and T15 Pro is a momentary switch, but its default switch type was
2POS. This changes the default toTOGGLE, which is what the T14 already uses for its momentary SF.radio/src/boards/hw_defs/t15.json,t15pro.json: SFdefaultchanged from2POStoTOGGLE.web/public/radios.json: regenerated withweb/scripts/gen-radios-json.js.Effect on existing users: none. Switch defaults are applied before
radio.ymlis loaded, and every switch's type is always written toradio.yml. Radios that already have settings keep their stored SF type. The new default only applies to a freshradio.yml, a factory reset, and new radio settings in Companion.Testing: built T15 and T15 Pro firmware; the generated switch table has
SWITCH_TOGGLEfor SF. The hw_defs JSON validator passes.Backport: on 2.12 the defaults live in
radio/util/hw_defs/switch_config.py(no committed JSON), so the backport is a hand change to thet15andt15proSF entries there instead of a cherry-pick.The same fix for the T15-H7 has been pushed to #7851 and #7849.
🤖 Generated with Claude Code