Repository navigation
chore(fw): move more settings to JSON hw_defs files - #7866
Merged
Merged
Conversation
philmoz
added
compilation
Use JSON for rotary encoder settings for all radios. Move touch panel settings. Move USB settings. Move trainer settings. Add 'hardware' section to hal_settings.h. Remove SPORT_MAX_BAUDRATE from hal.h files.
Remove the duplicate "trainer" section copied from TX16S, which overrode the T18 pins (PC6/PC7 in/out, PB4 detect) with PC8/PC9/PA8. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Restore EXTI15_10_IRQ_Priority to 5 as previously defined in st16/hal.h. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The JSON files and models.py use a boolean, not a string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Restore the #if !defined(USE_EXTIx_IRQ) guard the hal.h blocks had, so two sections using the same EXTI group no longer redefine the priority macro; the first definition wins as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The other hardware fields (CPU, CPU_TYPE, HAS_*, SURFACE) are unused by the firmware, and generic names like CPU or SURFACE could clash with identifiers elsewhere. CPU_TYPE is already defined by CMake. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- V12: set has_audio_mute, as v12/hal.h defines AUDIO_MUTE_GPIO - NB4P: set surface, as the firmware defines SURFACE_RADIO for it - V16: add touch_int_exti_line/port/syscfgline, which horus/hal.h previously defined for every touch board Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Emit SURFACE_RADIO in hal_settings.h when the JSON hardware section sets surface, and drop the hand-written defines for MT12 and NB4P. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
T15-H7 landed on main after this branch was started. Give it the same treatment as T15 Pro, which it is based on: USB, trainer (plus its detect pin) and touch settings move from hal.h to the JSON, and the unused HAS_SPORT_UPDATE_CONNECTOR goes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
force-pushed
the
philmoz/json-settings
branch
from
October 6, 2026 03:43
ef048cd to
99164f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: