Skip to content

fix(v14): SYS/MDL keys not working - #7479

Merged
pfeerick merged 2 commits into
EdgeTX:mainfrom
helloradiosky:hrs-v14-sys-mdl
Jul 15, 2026
Merged

pfeerick merged 2 commits into
EdgeTX:mainfrom
helloradiosky:hrs-v14-sys-mdl

Conversation

@helloradiosky

@helloradiosky helloradiosky commented Jun 21, 2026 •

Copy link
Copy Markdown
Contributor

Fixed the issue where SYS/MDL functions were not working in V14

Summary by CodeRabbit

  • New Features
    • Added platform support for a new radio device manufacturer and configuration (including the relevant board revision).
    • Extended key-mapping behavior to the new platform configuration to keep navigation controls consistent.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds MANUFACTURER_HELLORADIOSKY for the PCBREV V14 build. The navigation header derives NAVIGATION_X7_HRS from that macro when RADIO_T8 is absent and applies the existing X7_RM key mappings to it.

Changes

HelloRadioSky Navigation Support

Layer / File(s) Summary
Build definition for V14 board revision
radio/src/targets/taranis/CMakeLists.txt
Adds -DMANUFACTURER_HELLORADIOSKY to the PCBREV STREQUAL V14 branch.
NAVIGATION_X7_HRS macro and key-mapping
radio/src/gui/navigation/navigation.h
Defines NAVIGATION_X7_HRS when MANUFACTURER_HELLORADIOSKY is set and RADIO_T8 is not, then includes it in the existing X7 key-mapping condition.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • EdgeTX/edgetx#7480: Makes the corresponding HelloRadioSky navigation and key-mapping updates in the same navigation header.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too minimal and does not follow the required template sections like 'Fixes #' and 'Summary of changes'. Add the required template sections, including a Fixes # reference and a brief Summary of changes with the V14 SYS/MDL fix details.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely describes the main fix for V14 SYS/MDL key handling.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pfeerick pfeerick changed the title Fixed SYS/MDL functions were not working in V14 fix(v14): SYS/MDL functions not working correctly Jun 21, 2026
@pfeerick pfeerick changed the title fix(v14): SYS/MDL functions not working correctly fix(v14): SYS/MDL keys not working Jul 15, 2026
@pfeerick pfeerick added the bug/regression ↩️ A new version of EdgeTX broke something label Jul 15, 2026
@pfeerick pfeerick added this to the 3.0 milestone Jul 15, 2026
@pfeerick
pfeerick merged commit d2609a4 into EdgeTX:main Jul 15, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug/regression ↩️ A new version of EdgeTX broke something

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants